-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the DockManager does not hide the floating widgets #380
Comments
Sorry, but this is not a bug. It is not intended that hiding the CDockManager hides floating widgets. |
@githubuser0xFFFF |
I don't like the idea to add more complexity for a very special corner case and I also don't like the idea that hiding the dock manager hides the floating widgets. I don't even have an idea why someone would like to hide the dock manager. So I'm sorry but I'm not convinced and will not accept a pull request. |
@githubuser0xFFFF "I don't even have an idea why someone would like to hide the dock manager." This may be relevant when your application has a welcome widget. Basically, you store the welcome widget and the main widget (a dock manager) in a QStackedLayout. And you then show either the welcome widget when no project/file is opened and the main widget when a project is opened. So then, you would expect the floating widgets to be hidden when moving back to the welcome view after user closed its project/file. An alternative to using eConfigFlag would be to add a "hideManagerAndFloatingWidgets" function to CDockManager that would simply hide the floating widgets and remember them to be shown back when QShowEvent is executed. But I won't insist, this is your lib, if you don't want that we will implement it on our side. Just let me know. |
You can create a clean pull request. I would prefer the |
When you call
hide()
on theads::CDockManager
while some childs are floating, you would expect them to be hidden as well, but they remain visible.The text was updated successfully, but these errors were encountered: