Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate accessibility rubocop rule ImageHasAlt from dotcom to erblint-github #105

Conversation

bolonio
Copy link

@bolonio bolonio commented Jul 28, 2022

Context

The motivation of rubocop-github is to open-source our accessibility rubocop rules so non-GitHub people can benefit from them, have a space to provide comprehensive rule documentation, and also allow rules to be shared between Rails projects.

This PR migrates the accessibility rule ImageHasAlt from dotcom to rubocop-github

Related Issue

@bolonio bolonio requested review from owenniblock and khiga8 July 28, 2022 13:40
@khiga8
Copy link

khiga8 commented Jul 28, 2022

We should also update one of the config files so these accessibility rules are pulled in easily. Maybe config/default.yml?

Or do you think it should be in an accessibility-specific one? Maybe a new config/accessibility.yml?

Copy link

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we create a new accessibility folder to house the accessibility rules?

This will ensure the file path reflects the module structure.

module RuboCop
  module Cop
    module GitHub
      module Accessibility

Then the file names shouldn't include rails_

Copy link
Member

@owenniblock owenniblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesomeeee

@bolonio bolonio merged commit 3399237 into master Jul 29, 2022
@bolonio bolonio deleted the accessibility/issues/1430/migrate-a11y-rubocop-rules-image-has-alt branch July 29, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants