Delete legacy config #101
Merged
Delete legacy config #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintaining a separate "edge" config and "legacy" config probably served us well [back around the time we were migrating to rubocop 0.68](d533765), but it's not working well for us anymore. Things changed often before rubocop 1.0, and there are versions out there that don't work perfectly with either of these configs (see #86, for example). This commit sets a version constraint for rubocop ">= 1.0.0" and deletes the `*_deprecated.yml` files that only worked with rubocop < 0.68. With the deprecated files deleted, it also consolidates the remaining files into default.yml and rails.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining a separate "edge" config and "legacy" config probably served
us well back around the time we were migrating to rubocop 0.68, but it's not
working well for us anymore. Things changed often before rubocop 1.0,
and there are versions out there that don't work perfectly with either
of these configs (see #86,
for example).
This commit sets a version constraint for rubocop ">= 1.0.0" and deletes
the
*_deprecated.ymlfiles that only worked with rubocop <0.68. With the deprecated files deleted, it also consolidates the
remaining files into default.yml and rails.yml.