Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move customElements define calls to index.js and refactor #209

Merged
merged 1 commit into from
Nov 23, 2022
Merged

move customElements define calls to index.js and refactor #209

merged 1 commit into from
Nov 23, 2022

Commits on Nov 22, 2022

  1. move customElements define calls to index.js and refactor 

    This moves the `customeElements.define` calls from each respective
element and into the index.js file. This is useful for if we wish to
load the components classes without defining the custom element.

In addition, this changes the pattern of how we register the custom
elements, to allow for HMR, as we did in
github/catalyst#197.
    @keithamus
    keithamus committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    a885458 View commit details
    Browse the repository at this point in the history