Observe time zone name attribute #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful since developers (and CI) will run these tests in different timezones.
manuelpuyol
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the
time-zone-nameattribute does not trigger a re-render of the<local-time>component. This behavior is a bug that I'm fixing in this pull request by addingtime-zone-nameto the list of observed attributes inExtendedTimeElement.https://developer.mozilla.org/en-US/docs/Web/Web_Components/Using_custom_elements
To be able to test this change, we need to pin the timezone. I pinned it to Dubai time since it seems to me to be a well-supported timezone but not typical for systems to default to like GMT, UTC, or any American timezones.
References
StackOverflow - How to pin a timezone in Chrome