Merge pull request #212 from github/fix-typo-in-observed-attributes

fix typo in observed attributes
github · Nov 23, 2022 · b643852 · b643852
2 parents cc5096d + e229db7
commit b643852
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/relative-time-element.ts b/src/relative-time-element.ts
@@ -97,7 +97,7 @@ export default class RelativeTimeElement extends HTMLElement implements Intl.Dat
       'year',
       'time-zone-name',
       'prefix',
-      'threhsold',
+      'threshold',
       'tense',
       'precision',
       'format',

diff --git a/test/relative-time.js b/test/relative-time.js
@@ -78,6 +78,19 @@ suite('relative-time', function () {
     assert.notEqual(nextDisplay, display)
   })
 
+  test('all observedAttributes have getters', async function () {
+    const ALLOWED_PROPERTIES = ['time-zone-name']
+
+    const members = [
+      ...Object.getOwnPropertyNames(RelativeTimeElement.prototype),
+      ...Object.getOwnPropertyNames(HTMLElement.prototype),
+      ...ALLOWED_PROPERTIES
+    ]
+    const observedAttributes = new Set(RelativeTimeElement.observedAttributes)
+    for (const member of members) observedAttributes.delete(member)
+    assert.empty([...observedAttributes], 'observedAttributes that arent class members')
+  })
+
   test("doesn't error when no date is provided", function () {
     const element = document.createElement('relative-time')
     assert.doesNotThrow(() => element.attributeChangedCallback('datetime', null, null))