-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom domain simplifaction #163
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ee55a1d
add check for cname->domain->pages
tsusdere 010b037
start testing
tsusdere 2eea686
add check for CNAME host
tsusdere 0ea9a33
simplify check
tsusdere e12ea43
add test to check CNAMe points to pages IP
tsusdere d02c892
get the domain that points to pages
tsusdere 3f7dfc5
fix linting
tsusdere 8d25b39
remove extra line
tsusdere 54a4d60
add test to check not pages
tsusdere 7034496
fix typo
tsusdere 5442f62
add random CNAME test
tsusdere b3c9a7a
only support `www` cnames and bump version
tsusdere e2ba643
Update domain_spec.rb
tsusdere cf8d395
Update domain_spec.rb
tsusdere d67d170
add check for domain name
tsusdere a2b1ada
lint
tsusdere 0ca4bb0
add method to check
tsusdere 2beccba
Update domain.rb
tsusdere 4e3f79a
Update domain.rb
tsusdere 68a64e8
Update domain.rb
tsusdere 49e4dad
rubocop fix
tsusdere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,6 @@ | |
|
||
module GitHubPages | ||
module HealthCheck | ||
VERSION = "1.18.2" | ||
VERSION = "1.18.3" | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function seems not check the cname point to A record which points to pages.
Does this allow the user input arbitrary cname?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should the main thing is that we are checking for is that the
CNAME
doesn't already point to us then we run this checkpages-health-check/lib/github-pages-health-check/domain.rb
Line 468 in 8d25b39
I have a test that checks if it points to it but let me add a test in the event that it doesn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mainly mean if we want to only support
www.fontawesome.it
=>fontawesome.it
=> pagesxxxor loosely support
blog.fontawesome.it
=>fontawesome.it
=>pagesxxxx
hmmm loosely is fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh I see let me double check on that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like we just want to support
www.fontawesome.it
=>fontawesome.it
=> pages where we match thehost
after thewww