Fix CI which is broken on master #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 26, 2020 09:17
CI on master was failing due to rubocop errors, and also there were a number of noisy warnings. This: - fixes the rubocop config for cops that have been renamed upstream - adds missing cops that rubocop was complaining about (enabled: false) - updates the targeted version to a supported Ruby - deletes duplicate cops - fixes an incorrectly namespaced cop And then finally I ran rubocop with autocorrect to fix the various complaints that it had about the codebase.
tcbyrd
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not anyone's fault. It is just the
passage of time, and general code rot. Or, maybe
it's just dependency management hell. Not sure anymore.
CI on master was failing due to rubocop errors, and also there were a
number of noisy warnings.
This:
And then finally I ran rubocop with autocorrect to fix the various
complaints that it had about the codebase.
Once that was fixed CI started failing because of an outdated
CDN IP list, so I fixed that again.
At that point, CI seemed happy, but there were still warnings locally, so I went ahead and fixed that as well.Update: 2.4 choked on the fix. Took it off.