Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Sends 9gag title, and HTML Entiies are decoded. Added jsdom dependency. #1164

Closed
wants to merge 1 commit into from
Closed

Conversation

luijose
Copy link

@luijose luijose commented Oct 4, 2013

Straight forward modification to add support for 9gag title printing, with HTML entities decoded (so you won't get titles like ""This is the title""). Had to add the jsdom dependency in order to implement HTML entities decoding.

@technicalpickles
Copy link
Contributor

If we're adding a dependency, it would also be a good opportunity to move it to an external package. We've found it's a lot easier to manage dependencies that way.

@luijose any interesting in taking that on? Check out #1113 for more infos

@luijose
Copy link
Author

luijose commented Oct 7, 2013

Sure thing; should be ready now. Check it out at:
https://github.com/luijose/hubot-9gag

On Mon, Oct 7, 2013 at 10:37 AM, Josh Nichols notifications@github.comwrote:

If we're adding a dependency, it would also be a good opportunity to move
it to an external package. We've found it's a lot easier to manage
dependencies that way.

@luijose https://github.com/luijose any interesting in taking that on?
Check out #1113 #1113 for
more infos


Reply to this email directly or view it on GitHubhttps://github.com//pull/1164#issuecomment-25813515
.

@technicalpickles
Copy link
Contributor

And so it has been forked.

I was thinking of how to handle migrations like this, and I think just adding a simple deprecation with a pointer to the new package would be a good start.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants