Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim trailing whitespace #2728

Merged
merged 1 commit into from
Jun 17, 2018
Merged

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jun 5, 2018

Reasons for making this change:

Trailing whitespace is ugly.

Links to documentation supporting these [rule] changes:

n/a

@shiftkey
Copy link
Member

@jayvdb thanks!

@shiftkey shiftkey merged commit a580262 into github:master Jun 17, 2018
@jayvdb
Copy link
Contributor Author

jayvdb commented Jun 18, 2018

@shiftkey , any chance we can add some CI to prevent regressions?
I've done the same at https://github.com/dvcs/gitignore/blob/master/.travis/check-whitespace.sh (enhanced at toptal/gitignore#117)

I'd be happy to implement it, ideally using Travis-CI, either raw .sh using git, or in any major scripting language which you prefer, provided it has a wildmatch-like library so that it can grow to check validity of rules and possibly also check inter-relations between rules.

@jayvdb jayvdb deleted the trim-trailing-spaces branch June 18, 2018 04:01
jayvdb added a commit to jayvdb/pypi-mobans that referenced this pull request Jun 18, 2018
Especially removes trailing whitespace with
upstream patch github/gitignore#2728
@shiftkey
Copy link
Member

@jayvdb I've enabled Travis with an example build that's now passing https://travis-ci.org/github/gitignore/builds/393575258 - feel free to build upon that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants