Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a logging interface #789

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

abeyum
Copy link
Contributor

@abeyum abeyum commented Oct 7, 2019

Description

Related issue: #786

This PR allows developers to write gh-ost logs to where they see fit by extending an interface instead of relying on the default outbrain logs.

cc: @shlomi-noach

@shlomi-noach shlomi-noach changed the base branch from master to logging-interface-contrib December 11, 2019 05:02
@abeyum
Copy link
Contributor Author

abeyum commented Dec 16, 2019

@shlomi-noach I noticed you've taken some action to update this pull request, looks like it has passed all the checks. Can we merge this pull request?

@shlomi-noach shlomi-noach self-requested a review December 16, 2019 16:52
@shlomi-noach
Copy link
Contributor

👋 @abeyum indeed I did. I'm rotating between a few issues/PRs. I apologize, but I'm still going to push this a bit, and would only be able to look into it again after end of year. I appreciate your PR and the time you took to write it.

@abeyum
Copy link
Contributor Author

abeyum commented Apr 23, 2020

Hello @shlomi-noach,

Any chance you are free to take a look and merge? PR has passed all checks and there are no merge conflicts.

@tomkrouper
Copy link

ping @jfudally. Is this something you can look at?

@shlomi-noach
Copy link
Contributor

Hi there. I'm responding because I was @-mentioned directly. I no longer work at GitHub, am no longer an owner of this repository, and am actually not working right now. I'm taking a personal break from gh-ost for a while, and will probably return to work on gh-ost at some point in the future. I'm sorry I couldn't push this through earlier.

@abeyum
Copy link
Contributor Author

abeyum commented Jul 15, 2020

@jfudally Any chance we can review and merge this soon?

@jfudally jfudally requested review from jfudally and removed request for shlomi-noach July 21, 2020 20:52
@jfudally
Copy link

@abeyum Thank you for the submission, I appreciate the work you put into this. Sorry it's taken so long to get this in!

@jfudally jfudally merged commit 6b6f9ec into github:logging-interface-contrib Jul 21, 2020
@SocalNick SocalNick mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants