Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use NO_AUTO_VALUE_ON_ZERO #723

Merged
merged 5 commits into from
Jun 10, 2019
Merged

Always use NO_AUTO_VALUE_ON_ZERO #723

merged 5 commits into from
Jun 10, 2019

Conversation

shlomi-noach
Copy link
Contributor

Fixes #722

gh-ost should always use NO_AUTO_VALUE_ON_ZERO because the values it reads are inherently absolutely true, and it should not convert zero auto_increment values into other values.

@shlomi-noach shlomi-noach temporarily deployed to production/mysql_role=ghost_testing March 24, 2019 09:34 Inactive
@shlomi-noach
Copy link
Contributor Author

Sent to testing

@shlomi-noach
Copy link
Contributor Author

This seems good in testing. @ggunson could you please review the conjecture that adding NO_AUTO_VALUE_ON_ZERO to gh-ost's sql_mode is always the correct thing to do?

@shlomi-noach
Copy link
Contributor Author

This went under extensive testing. Merging shortly.

@shlomi-noach shlomi-noach merged commit 8113d38 into master Jun 10, 2019
@shlomi-noach shlomi-noach deleted the no-auto-value-on-zero branch June 10, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggunson ggunson Awaiting requested review from ggunson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding NO_AUTO_VALUE_ON_ZERO to sql_mode
1 participant
@shlomi-noach