Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(): feat-set-binlogsyncer-maxreconnectattempts #1279

Merged
merged 1 commit into from
May 25, 2023
Merged

feat(): feat-set-binlogsyncer-maxreconnectattempts #1279

merged 1 commit into from
May 25, 2023

Conversation

shaohk
Copy link
Contributor

@shaohk shaohk commented May 24, 2023

feat-set-binlogsyncer-maxreconnectattempts

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue: https://github.com/github/gh-ost/issues/0123456789

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR [briefly explain what it does]

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@shaohk
Copy link
Contributor Author

shaohk commented May 24, 2023 •
edited
Loading

@timvaillancourt
I'm sorry, the previous pull request https://github.com/github/gh-ost/pull/1232 was automatically closed because I deleted the branch that I forked from. I have created a new one, could you please take a look?
tks!

@timvaillancourt timvaillancourt self-requested a review May 25, 2023 20:45
timvaillancourt
timvaillancourt approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Thanks @shaohk

@timvaillancourt timvaillancourt merged commit 0a033c7 into github:master May 25, 2023
RainbowDashy pushed a commit to bytebase/gh-ost that referenced this pull request Aug 22, 2023
@shaohk @RainbowDashy
feat(feat-set-binlogsyncer-maxreconnectattempts): feat-set-binlogsync…
8a52c16 
…er-maxreconnectattempts (github#1279)

Co-authored-by: shaohoukun <shaohoukun@meituan.com>
RainbowDashy pushed a commit to bytebase/gh-ost that referenced this pull request Aug 22, 2023
@shaohk @RainbowDashy
feat(feat-set-binlogsyncer-maxreconnectattempts): feat-set-binlogsync…
dd3d99a 
…er-maxreconnectattempts (github#1279)

Co-authored-by: shaohoukun <shaohoukun@meituan.com>
d-bytebase pushed a commit to bytebase/gh-ost that referenced this pull request Aug 22, 2023
@RainbowDashy @shaohk
feat(feat-set-binlogsyncer-maxreconnectattempts): feat-set-binlogsync…
208d37b 
…er-maxreconnectattempts (github#1279) (#30)

Co-authored-by: Shao Hou Kun <shaohk@yeah.net>
Co-authored-by: shaohoukun <shaohoukun@meituan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvaillancourt timvaillancourt timvaillancourt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaohk @timvaillancourt