Print status to migrationContext logger #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
SocalNick
changed the title
SocalNick
changed the title
SocalNick
changed the title
Svoyu
approved these changes
Oct 27, 2022
|
Hi @Svoyu - I see you approved this change, but I can't merge it because none of the workflows have run. It says, "First-time contributors need a maintainer to approve running workflows." Are you able to approve those to run? |
…r-simple-alternative
dm-2
approved these changes
Nov 14, 2022
Hi @SocalNick, I've approved the workflows to run - all looks good! 😄 (P.S. I think @syoyu is a spam user so I've reported their account) |
This was referenced Nov 14, 2022
|
Hi there, we're currently using a fork to get this functionalit - are there any plans for a new release soon? We can use the commit hash in the meanwhile if that's not in the works yet. @dm-2 |
Closed
icyflame
added a commit
to icyflame/gh-ost
that referenced
this pull request
Jan 31, 2024
The string `status` has the character `%` after the progress percentage number. When printed once again using the `Infof` function, this `%` is read as a directive for formatting and ends up showing `MISSING` in the output as shown below: 2024-01-31 12:49:54 INFO Copy: 0/0 100.0%!;(MISSING) Applied: 0; Backlog: 0/1000; Time: 0s(total), 0s(copy); streamer: mysql_bin.000002:79674; Lag: 0.00s, HeartbeatLag: 0.02s, State: migrating; ETA: due Simply changing `Infof` to `Info` does not work here because `this.migrationContext.Log` is an object of the type `DefaultLogger` in this repository, which uses the library https://github.com/outbrain/golib/log. That library uses formatting __even__ when the `Info`function is called: https://github.com/outbrain/golib/blob/2531e5dbcc71b6f8a4ccf1205c209ae89b7529fc/log/log.go#L191-L193 If this patch is not acceptible, then I can also just remove this line. The migration context logger prints the messages which are already printed to STDOUT once again to STDERR with the current time as a prefix. This change was introduced in the commit https://github.com/github/gh-ost/blob/515aa72d3d9b756e454b0168b4e57bc599b45e36/go/logic/migrator.go#L1039, introduced in the PR github#1194.
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a simple alternative to #1193
A Pull Request should be associated with an Issue.
Related issue: #1026
Description
Status is currently only sent to stdout. We'd like the status to also be sent to the migrationContext logger.
script/cibuildreturns with no formatting errors, build errors or unit test errors.