Remove end-of-life MySQL 5.5.x version #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashiq
approved these changes
Feb 25, 2022
dm-2
approved these changes
Feb 25, 2022
|
Overriding merge requirements as |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes support for MySQL 5.5.x, which reached end-of-life on December 3, 2018
For the most part this PR removes testing for 5.5.x and a single hack to support 5.5.x in
go/logic/inspect.go. This hack assumedbinlog_row_image=FULLif the query for this global-variable failed, as it will do on 5.5.x (variable doesn't exist)Removing this hack should make things more resilient in a situation where the
select @@global.binlog_row_imagequery fails for a different reasonscript/cibuildreturns with no formatting errors, build errors or unit test errors.