o1 streaming error

[simonw]

I tried this:

% gh models run o1
>>> hi

And got this:

Error: bad request
{
  "error": {
    "message": "Unsupported value: 'stream' does not support true with this model. Supported values are: false.",
    "type": "invalid_request_error",
    "param": "stream",
    "code": "unsupported_value"
  }
}

It looks like o1 doesn't support streaming, but gh models run tries to request streaming for it.

[simonw]

I think this code needs updating to also check for o1:

gh-models/internal/azuremodels/azure_client.go

Lines 43 to 49 in c323588

	func (c *AzureClient) GetChatCompletionStream(ctx context.Context, req ChatCompletionOptions) (*ChatCompletionResponse, error) {
	// Check if the model name is `o1-mini` or `o1-preview`
	if req.Model == "o1-mini" || req.Model == "o1-preview" {
	req.Stream = false
	} else {
	req.Stream = true
	}