Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update about-self-hosted-runners.md #930

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Update about-self-hosted-runners.md #930

merged 2 commits into from
Nov 5, 2020

Conversation

pholleran
Copy link
Contributor

@pholleran pholleran commented Oct 30, 2020

Why:

https://github.com/github/docs-content/issues/3188

What's being changed:

codeload.github.com is being added to the DNS entries that need to be open for self-hosted runners to work. Several actions, when downloaded to the runner, need to load content from codeload.

Check off the following:

@welcome
Copy link

welcome bot commented Oct 30, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@pholleran pholleran added the content This issue or pull request belongs to the Docs Content team label Oct 30, 2020
@Suya159357

This comment has been minimized.

@Suya159357

This comment has been minimized.

@janiceilene
Copy link
Contributor

Thanks for opening a PR @pholleran! I'll get this triaged for review.

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 2, 2020
Copy link
Contributor

@rachmari rachmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pholleran thanks for the update! I'll get this merged right away. 🚢

@rachmari rachmari self-assigned this Nov 5, 2020
@rachmari rachmari merged commit afcc2cf into main Nov 5, 2020
@rachmari rachmari deleted the codeload-api-endpoint branch November 5, 2020 00:49
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants