-
Notifications
You must be signed in to change notification settings - Fork 59.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md #908
Conversation
I ran the steps today on mac OS Catalina and it did not work for me. I had to make two changes that I updated in the doc.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Thanks for opening a pull request @poonam-lamba! I'll get this triaged for review ✨ |
...t/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md
Outdated
Show resolved
Hide resolved
...t/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@poonam-lamba - Many thanks for creating this pull request. Although we direct people to use a passphrase I think it's helpful to provide this extra information for people who use a key without a passphrase.
I've suggested a few small changes.
Thanks again for helping to improve GitHub documentation. 👍
…ey-and-adding-it-to-the-ssh-agent.md Co-authored-by: hubwriter <hubwriter@github.com>
…ey-and-adding-it-to-the-ssh-agent.md Add space between sentences, plus slight rewording.
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
No response from author to my commit here |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Co-authored-by: Lana Brindley <github@lanabrindley.com>
I ran the steps today on mac OS Catalina and it did not work for me. I had to make two changes that I updated in the doc.
Why:
What's being changed:
Check off the following: