Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md #908

Merged
merged 6 commits into from
Nov 20, 2020

Conversation

poonam-lamba
Copy link
Contributor

I ran the steps today on mac OS Catalina and it did not work for me. I had to make two changes that I updated in the doc.

Why:

What's being changed:

Check off the following:

I ran the steps today on mac OS Catalina and it did not work for me. I had to make two changes that I updated in the doc.
@welcome
Copy link

welcome bot commented Oct 29, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks for opening a pull request @poonam-lamba! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 2, 2020
@hubwriter hubwriter self-assigned this Nov 4, 2020
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poonam-lamba - Many thanks for creating this pull request. Although we direct people to use a passphrase I think it's helpful to provide this extra information for people who use a key without a passphrase.

I've suggested a few small changes.

Thanks again for helping to improve GitHub documentation. 👍

poonam-lamba and others added 4 commits November 5, 2020 09:19
…ey-and-adding-it-to-the-ssh-agent.md

Co-authored-by: hubwriter <hubwriter@github.com>
…ey-and-adding-it-to-the-ssh-agent.md


Add space between sentences, plus slight rewording.
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 19, 2020
@hubwriter
Copy link
Contributor

No response from author to my commit here
7566ecb
so I'm going to assume all is good here and merge this now.

@hubwriter hubwriter merged commit b184ba9 into github:main Nov 20, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team stale There is no recent activity on this issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants