Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to creating a repository dispatch event #731

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

Deborah-Digges
Copy link
Member

@Deborah-Digges Deborah-Digges commented Oct 23, 2020

When I try to search for this term, a lot of related but less relevant pages rank higher than GitHub docs. I've added the link to how to create a repository dispatch event to make it more discoverable.

Screen Shot 2020-10-22 at 8 27 34 PM

Why:

What's being changed:

Check off the following:

@Deborah-Digges
Copy link
Member Author

This test seems to be failing

test('does not use old site.data variable syntax', async () => {

I think I need to use a relative path to the docs - will update to do so!

@janiceilene
Copy link
Contributor

Thanks so much for the PR @Deborah-Digges! I'll get it triaged for review ✨

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! labels Oct 23, 2020
Copy link
Contributor

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @Deborah-Digges! Nice spelunking on the correct relative link @nschonni!

@runleonarun runleonarun merged commit 99a9ee4 into github:main Nov 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants