Skip to content

Fix default GPG key type #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2020
Merged

Fix default GPG key type #567

merged 4 commits into from
Oct 21, 2020

Conversation

sturman
Copy link
Contributor

@sturman sturman commented Oct 15, 2020

2020-10-15_23-25

Why:

What's being changed:

step

  • At the prompt, specify the kind of key you want, or press Enter to accept the default RSA and DSA.

replaced with

  • At the prompt, specify the kind of key you want, or press Enter to accept the default RSA and RSA.

Check off the following:

@welcome
Copy link

welcome bot commented Oct 15, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks for opening a PR @sturman! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 15, 2020
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻 @sturman

Thanks for reporting this discrepancy and fixing it ✨
It was particularly helpful that you included a screenshot to show the expected prompt.

@felicitymay felicitymay merged commit bb8e5e4 into github:main Oct 21, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@felicitymay felicitymay added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Nov 6, 2020
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* Add note about VPC details

* Apply suggestions from code review

Co-authored-by: emizero <83252792+emizero@users.noreply.github.com>
Co-authored-by: Jacob Prall <prall.jacob@gmail.com>

* Apply suggestions from code review

* Update mst/vpc-peering.md

Co-authored-by: emizero <83252792+emizero@users.noreply.github.com>

Co-authored-by: Jacob Prall <prall.jacob@gmail.com>
Co-authored-by: emizero <83252792+emizero@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants