Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Add section about group/ungroup commands #482

Merged
merged 8 commits into from
Nov 4, 2020

Conversation

Simran-B
Copy link
Contributor

@Simran-B Simran-B commented Oct 13, 2020

Why:

Missing in Actions documentation, but available here:
https://github.com/actions/toolkit/blob/main/docs/commands.md#group-and-ungroup-log-lines

What's being changed:

  • Add new section about grouping log lines
  • Improve table markup
  • Change headline level of Multline strings example from h4 to h5 (make Example a child section of Multiline string section)

image


Changed headline level:

image


Check off the following:

@Simran-B
Copy link
Contributor Author

Hm, should I retake the screenshot at 150% or 200% browser scale? That would make it look crisper on high density screens.

@janiceilene
Copy link
Contributor

Thanks so much @Simran-B! I'll get this triaged for review 🎉

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 14, 2020
@Simran-B
Copy link
Contributor Author

The screen shot looks much better on my phone now, but it's displayed quite large on desktop. Is there an existing solution to adjust the size based on native pixel size or something along this line?

https://docs-482--actions-group-comman.herokuapp.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#grouping-log-lines

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Oct 22, 2020
@janiceilene
Copy link
Contributor

Sorry about the delay @Simran-B! We've got quite a few things going on that our small team is taking care of, but this is definitely not stale and we'll get it reviewed 💛

@janiceilene janiceilene added hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! and removed stale There is no recent activity on this issue or pull request labels Oct 23, 2020
Copy link
Contributor

@rachmari rachmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Simran-B thanks for catching this and updating the docs! ✨ I just had one suggestion to change the language to match the tone style guide for the docs. Once that is updated, I can get this shipped for you! 🚢

@rachmari rachmari self-assigned this Nov 3, 2020
Co-authored-by: Simran <Simran-B@users.noreply.github.com>
Copy link
Contributor

@rachmari rachmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Simran-B thank you so much for cleaning up the table and adding the group command! This looks fantastic. 🙌 I'm going to ship this right away. 🚀 🚢

@rachmari rachmari merged commit 4620400 into github:main Nov 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants