Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add answer to trubs dev app #3929

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
86ddb9e
Update issue templates
janiceilene Jan 19, 2021
ec72465
remove checkboxes (not supported)
janiceilene Jan 19, 2021
710b06d
update engineering template
janiceilene Jan 19, 2021
1e06ed5
un-grump linter errors
janiceilene Jan 19, 2021
6bdc55f
incorporated lee's :sparkles: suggestions!
janiceilene Jan 20, 2021
7099012
Merge branch 'main' into janiceilene-patch-1
janiceilene Jan 20, 2021
2fa1972
Update .github/ISSUE_TEMPLATE/improve-existing-docs.yml
janiceilene Jan 20, 2021
1996932
add intentation
janiceilene Jan 20, 2021
f57c180
Run linter
heiskr Jan 21, 2021
c0acc95
Update .github/ISSUE_TEMPLATE/improve-the-site.yml
janiceilene Jan 25, 2021
929f092
Update .github/ISSUE_TEMPLATE/improve-existing-docs.yml
janiceilene Jan 25, 2021
81e20bd
Update .github/ISSUE_TEMPLATE/improve-the-site.yml
janiceilene Jan 25, 2021
17321de
Update site text areas with @chiedo's suggestions
janiceilene Jan 25, 2021
5ad795a
Update .github/ISSUE_TEMPLATE/improve-the-site.yml
janiceilene Jan 26, 2021
a77ef59
Merge branch 'main' into janiceilene-patch-1
janiceilene Jan 29, 2021
786ba7e
Merge branch 'main' into janiceilene-patch-1
janiceilene Jan 29, 2021
63531d5
Merge branch 'main' into janiceilene-patch-1
janiceilene Feb 1, 2021
283ee4e
Merge branch 'main' into janiceilene-patch-1
chiedo Feb 1, 2021
c604f44
Merge branch 'main' into janiceilene-patch-1
janiceilene Feb 1, 2021
bece5e2
rename from .yml to .yaml
janiceilene Feb 1, 2021
f15d9d3
Add `---` to the first line
janiceilene Feb 1, 2021
c6fc0a1
fix yaml
janiceilene Feb 8, 2021
68cf76e
Convert templates to new format - will work automagically on Feb 19
Feb 11, 2021
0a43b50
Merge pull request #3620 from deniseyu/fix-template
janiceilene Feb 11, 2021
3de04b9
Merge branch 'main' into janiceilene-patch-1
janiceilene Feb 11, 2021
5d81933
fix buggy output if 1 invalid link is found and add do-not-retry opti…
sarahs Feb 17, 2021
d0bce8f
repo sync
Octomerger Feb 18, 2021
46ccfc5
Run AB test on survey stars (#17861)
heiskr Feb 18, 2021
644ff42
repo sync
Octomerger Feb 18, 2021
8b8561d
Slash commands private beta (#17664)
lecoursen Feb 18, 2021
cc7a5dd
repo sync
Octomerger Feb 18, 2021
ad53fbb
update with intro (#17908)
megbird Feb 18, 2021
e3eff5b
repo sync
Octomerger Feb 18, 2021
219db8d
repo sync
Octomerger Feb 18, 2021
39b6854
add comment
sarahs Feb 18, 2021
b36513f
Merge branch 'main' of github.com:github/docs-internal into if-it-ain…
sarahs Feb 18, 2021
3543597
Merge pull request #17885 from github/if-it-aint-broke
sarahs Feb 18, 2021
4dded69
repo sync
Octomerger Feb 18, 2021
8148677
"Enable TLS" for Heroku Redis by ignoring self-signed TLS certificate…
JamesMGreene Feb 18, 2021
d7b0f62
repo sync
Octomerger Feb 18, 2021
f7150c5
run linter
rachmari Feb 18, 2021
380142c
use `pull_request_target` (#3783)
rachmari Feb 18, 2021
f009009
Quiet Repo Sync Stalls during Freezes (#17921)
chiedo Feb 19, 2021
e2ba289
Add note about no deployment_status events for inactive state (#3736)
lupine86 Feb 19, 2021
7991fa4
Branch was updated using the 'autoupdate branch' Actions workflow.
Octomerger Feb 19, 2021
17fd718
repo sync
Octomerger Feb 19, 2021
c51907a
Merge branch 'main' into janiceilene-patch-1
janiceilene Feb 19, 2021
a0703ea
Merge pull request #3019 from github/janiceilene-patch-1
janiceilene Feb 19, 2021
5cc4d0e
Revert "Update issue templates"
janiceilene Feb 19, 2021
387b383
Merge pull request #3797 from github/revert-3019-janiceilene-patch-1
janiceilene Feb 19, 2021
afd3cef
update repo sync (#17919)
rachmari Feb 19, 2021
f9b50ac
use new workflow filename routes for badges (#17518)
elbrenn Feb 19, 2021
6bee9ca
Change procedure to use the sidebar for assigning issues/PRs
ethanpalm Feb 19, 2021
de7e163
Split into two procedures
ethanpalm Feb 19, 2021
00e9817
repo sync (#17931)
Octomerger Feb 19, 2021
ca59f9a
Merge branch 'main' into repo-sync
rachmari Feb 19, 2021
87c41ef
repo sync
Octomerger Feb 19, 2021
2c141bb
repo sync
Octomerger Feb 19, 2021
b0867e6
Revert "update repo sync (#17919)" (#17933)
rachmari Feb 19, 2021
981e86a
repo sync
Octomerger Feb 19, 2021
8a750db
repo sync
Octomerger Feb 19, 2021
c9a5f7f
Action ran graphql script"update-files"
rachmari Feb 20, 2021
a8a2bbe
Allow Repo Sync to continue running during freezes (#17924)
chiedo Feb 22, 2021
111345f
Branch was updated using the 'autoupdate branch' Actions workflow.
Octomerger Feb 22, 2021
2cb77f7
GraphQL schema update
Octomerger Feb 22, 2021
08828f3
repo sync
Octomerger Feb 22, 2021
38cfcb7
Clarify how to create a CNAME (#2961)
ajs256 Feb 22, 2021
b7dc6f4
Incorporate reviewer feedback
ethanpalm Feb 22, 2021
e9b2148
Merge branch 'main' into sidebar-assignee-menu
ethanpalm Feb 22, 2021
3f491e5
Merge pull request #3804 from github/sidebar-assignee-menu
ethanpalm Feb 22, 2021
3de5c74
repo sync
Octomerger Feb 22, 2021
408fcdf
Remove an old redirect that no one has used in a long time (#17868)
heiskr Feb 22, 2021
bcd91a0
End survey stars AB test (#17907)
heiskr Feb 22, 2021
151bf2a
repo sync
Octomerger Feb 22, 2021
c043a43
Add .circleci/config.yml
Dmarch28 Feb 23, 2021
5e064ea
Merge remote-tracking branch 'origin/circleci-project-setup' into add…
Dmarch28 Feb 23, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Use the latest 2.1 version of CircleCI pipeline process engine. See: https://circleci.com/docs/2.0/configuration-reference
version: 2.1
# Use a package of configuration called an orb.
orbs:
# Declare a dependency on the welcome-orb
welcome: circleci/welcome-orb@0.4.1
# Orchestrate or schedule a set of jobs
workflows:
# Name the workflow "welcome"
welcome:
# Run the welcome/run job in its own container
jobs:
- welcome/run
5 changes: 3 additions & 2 deletions .github/workflows/repo-freeze-check.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
name: Repo Freeze Check

on:
pull_request:
workflow_dispatch:
pull_request_target:
types:
- opened
- reopened
Expand All @@ -21,7 +22,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Fail if repo merges are paused
if: ${{ env.FREEZE == 'true' }}
if: ${{ env.FREEZE == 'true' && github.ref != 'refs/heads/repo-sync' }}
run: |
echo 'Merges into the "main" branch on this repo are currently paused!'
exit 1
15 changes: 1 addition & 14 deletions .github/workflows/repo-sync-stalls.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,7 @@ on:
schedule:
- cron: '0 */2 * * *'

env:
FREEZE: ${{ secrets.FREEZE }}

jobs:
check-freezer:
name: Check for deployment freezes
runs-on: ubuntu-latest
steps:
- name: Exit if repo is frozen
if: ${{ env.FREEZE == 'true' }}
run: |
echo 'The repo is currently frozen! Exiting this workflow.'
exit 1 # prevents further steps from running

repo-sync-stalls:
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -60,7 +47,7 @@ jobs:
})
- name: Send Slack notification if workflow fails
uses: someimportantcompany/github-actions-slack-message@0b470c14b39da4260ed9e3f9a4f1298a74ccdefd
if: failure()
if: ${{ failure() }}
with:
channel: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
bot-token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}
Expand Down
14 changes: 0 additions & 14 deletions .github/workflows/repo-sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,10 @@ on:
schedule:
- cron: '*/15 * * * *' # every 15 minutes

env:
FREEZE: ${{ secrets.FREEZE }}

jobs:
check-freezer:
name: Check for deployment freezes
runs-on: ubuntu-latest
steps:
- name: Exit if repo is frozen
if: ${{ env.FREEZE == 'true' }}
run: |
echo 'The repo is currently frozen! Exiting this workflow.'
exit 1 # prevents further steps from running

repo-sync:
if: github.repository == 'github/docs-internal' || github.repository == 'github/docs'
name: Repo Sync
needs: check-freezer
runs-on: ubuntu-latest
steps:
- name: Check out repo
Expand Down
Binary file added assets/images/help/issues/assign_yourself.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/images/help/issues/assignee_menu.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -12,52 +12,31 @@ versions:

{% data reusables.repositories.actions-workflow-status-badge-into %}

If your workflow uses the `name` keyword, you must reference the workflow by name. If the name of your workflow contains white space, you'll need to replace the space with the URL encoded string `%20`. For more information about the `name` keyword, see "[Workflow syntax for {% data variables.product.prodname_actions %}](/articles/workflow-syntax-for-github-actions#name)."
You reference the workflow by the name of your workflow file.

```
https://github.com/<OWNER>/<REPOSITORY>/workflows/<WORKFLOW_NAME>/badge.svg
https://github.com/<OWNER>/<REPOSITORY>/actions/workflows/<WORKFLOW_FILE>/badge.svg
```
### Using the workflow file name

Alternatively, if your workflow doesn't have a `name`, you must reference the workflow file using the file path relative to the repository's root directory.

{% note %}

**Note:** Referencing the workflow file using the file path does not work if the workflow has a `name`.

{% endnote %}

```
https://github.com/<OWNER>/<REPOSITORY>/workflows/<WORKFLOW_FILE_PATH>/badge.svg
```

### Using a workflow name

This Markdown example adds a status badge for a workflow with the name "Greet Everyone." The `OWNER` of the repository is the `actions` organization and the `REPOSITORY` name is `hello-world`.

```markdown
![example workflow name](https://github.com/actions/hello-world/workflows/Greet%20Everyone/badge.svg)
```

### Using a workflow file path

This Markdown example adds a status badge for a workflow with the file path `.github/workflows/main.yml`. The `OWNER` of the repository is the `actions` organization and the `REPOSITORY` name is `hello-world`.
This Markdown example adds a status badge for a workflow with the file path `.github/workflows/main.yml`. The `OWNER` of the repository is the `github` organization and the `REPOSITORY` name is `docs`.

```markdown
![example workflow file path](https://github.com/actions/hello-world/workflows/.github/workflows/main.yml/badge.svg)
![example workflow](https://github.com/github/docs/actions/workflows/main.yml/badge.svg)
```

### Using the `branch` parameter

This Markdown example adds a status badge for a branch with the name `feature-1`.

```markdown
![example branch parameter](https://github.com/actions/hello-world/workflows/Greet%20Everyone/badge.svg?branch=feature-1)
![example branch parameter](https://github.com/github/docs/actions/workflows/main.yml/badge.svg?branch=feature-1)
```

### Using the `event` parameter

This Markdown example adds a badge that displays the status of workflow runs triggered by the `pull_request` event.

```markdown
![example event parameter](https://github.com/actions/hello-world/workflows/Greet%20Everyone/badge.svg?event=pull_request)
![example event parameter](https://github.com/github/docs/actions/workflows/main.yml/badge.svg?event=pull_request)
```
6 changes: 6 additions & 0 deletions content/actions/reference/events-that-trigger-workflows.md
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,12 @@ on:
deployment_status
```

{% note %}

**Note:** When a deployment status's state is set to `inactive`, a webhook event will not be created.

{% endnote %}

#### `fork`

Runs your workflow anytime when someone forks a repository, which triggers the `fork` event. For information about the REST API, see "[Create a fork](/rest/reference/repos#create-a-fork)."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ versions:

### About YAML syntax for workflows

Workflow files use YAML syntax, and must have either a `.yml` or `.yaml` file extension. If you're new to YAML and want to learn more, see "[Learn YAML in five minutes](https://www.codeproject.com/Articles/1214409/Learn-YAML-in-five-minutes)."
Workflow files use YAML syntax, and must have either a `.yml` or `.yaml` file extension. {% data reusables.actions.learn-more-about-yaml %}

You must store workflow files in the `.github/workflows` directory of your repository.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,29 @@ versions:

Anyone with write permissions to a repository can assign issues and pull requests.

### About issue and pull request assignees

You can assign up to 10 people to each issue or pull request, including yourself, anyone who has commented on the issue or pull request, anyone with write permissions to the repository, and organization members with read permissions to the repository. For more information, see "[Access permissions on {% data variables.product.prodname_dotcom %}](/articles/access-permissions-on-github)."

### Assigning an individual issue or pull request

{% data reusables.repositories.navigate-to-repo %}
{% data reusables.repositories.sidebar-issue-pr %}
3. Open the issue or pull request that you want to assign to someone.
4. If no one is assigned to an issue or pull request, click **assign yourself** to assign yourself.
![The assign yourself item](/assets/images/help/issues/assign_yourself.png)
5. In the right side menu, click **Assignees**.
![The Assignees menu item](/assets/images/help/issues/assignee_menu.png)
6. To assign the issue or pull request to a user, start typing their username, then click their name when it appears. You can select and add up to ten assignees to an issue or pull request.
![Issues assignment drop-down](/assets/images/help/issues/issues_assigning_dropdown.png)

### Assigning multiple issues or pull requests

{% data reusables.repositories.navigate-to-repo %}
{% data reusables.repositories.sidebar-issue-pr %}
3. Select the checkbox next to the items you want to assign to someone.
![Issues metadata checkbox](/assets/images/help/issues/issues_assign_checkbox.png)
4. In the upper-right corner, click **Assignee**.
4. In the upper-right corner, click **Assign**.
5. To assign the items to a user, start typing their username, then click their name when it appears. You can select and add up to ten assignees to an issue or pull request.
![Issues assignment drop-down](/assets/images/help/issues/issues_assigning_dropdown.png)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ The `dig` command, which can be used to verify correct configuration of DNS reco

### Configuring a subdomain

To set up a `www` or custom subdomain, such as `www.example.com` or `blog.example.com`, you must create a _CNAME_ file in your site's repository and configure a `CNAME` record with your DNS provider.
To set up a `www` or custom subdomain, such as `www.example.com` or `blog.example.com`, you must add your domain in the repository settings, which will create a CNAME file in your sites repository. After that, configure a CNAME record with your DNS provider.

{% data reusables.pages.navigate-site-repo %}
{% data reusables.repositories.sidebar-settings %}
Expand Down
2 changes: 1 addition & 1 deletion data/graphql/ghae/schema.docs-ghae.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -37067,7 +37067,7 @@ type VerifiableDomain implements Node {
id: ID!

"""
Whether this domain is required to exist for an organization policy to be enforced.
Whether this domain is required to exist for an organization or enterprise policy to be enforced.
"""
isRequiredForPolicyEnforcement: Boolean!

Expand Down
2 changes: 1 addition & 1 deletion data/graphql/schema.docs.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -40380,7 +40380,7 @@ type VerifiableDomain implements Node {
id: ID!

"""
Whether this domain is required to exist for an organization policy to be enforced.
Whether this domain is required to exist for an organization or enterprise policy to be enforced.
"""
isRequiredForPolicyEnforcement: Boolean!

Expand Down
1 change: 1 addition & 0 deletions data/release-notes/3-0/0.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
date: '2021-02-16'
intro: The minimum infrastructure requirements have increased for {% data variables.product.prodname_ghe_server %} 3.0+. For more information, see "[About minimum requirements for GitHub Enterprise Server 3.0 and later](/admin/enterprise-management/upgrading-github-enterprise-server#about-minimum-requirements-for-github-enterprise-server-30-and-later)."
sections:
features:
- heading: GitHub Actions
Expand Down
1 change: 1 addition & 0 deletions data/reusables/actions/learn-more-about-yaml.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
If you're new to YAML and want to learn more, see "[Learn YAML in five minutes](https://www.codeproject.com/Articles/1214409/Learn-YAML-in-five-minutes)."
6 changes: 0 additions & 6 deletions data/ui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@ helpfulness:
yes_feedback: Want to learn about new docs features and updates? Sign up for updates!
email_placeholder: email@example.com
no_feedback: We're continually improving our docs. We'd love to hear how we can do better.
category_label: What problem did you have?
category_default: Choose an option
category_unclear: Information was unclear
category_confusing: The content was confusing
category_unhelpful: The article didn't answer my question
category_other: Other
comment_label: Let us know what we can do better
optional: Optional
required: Required
Expand Down
32 changes: 0 additions & 32 deletions includes/helpfulness.html
Original file line number Diff line number Diff line change
Expand Up @@ -52,38 +52,6 @@
name="helpfulness-token"
aria-hidden="true"
/>
<p hidden data-help-no>
<label
class="d-block mb-1 f6"
for="helpfulness-category"
>
{% data ui.helpfulness.category_label %}
<span class="text-normal text-gray-light float-right ml-1">
{% data ui.helpfulness.required %}
</span>
</label>
<select
class="form-control select-sm width-full"
name="helpfulness-category"
id="helpfulness-category"
>
<option value="">
{% data ui.helpfulness.category_default %}
</option>
<option value="Unclear">
{% data ui.helpfulness.category_unclear %}
</option>
<option value="Confusing">
{% data ui.helpfulness.category_confusing %}
</option>
<option value="Unhelpful">
{% data ui.helpfulness.category_unhelpful %}
</option>
<option value="Other">
{% data ui.helpfulness.category_other %}
</option>
</select>
</p>
<p hidden data-help-no>
<label
class="d-block mb-1 f6"
Expand Down
6 changes: 4 additions & 2 deletions javascripts/experiment.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export function bucket (test) {
return hash % 2 ? TREATMENT : CONTROL
}

export async function sendSuccess (test) {
export function sendSuccess (test) {
return sendEvent({
type: 'experiment',
experiment_name: test,
Expand All @@ -21,8 +21,10 @@ export async function sendSuccess (test) {
}

export default function () {
// *** Example test code ***
// const testName = '$test-name$'
// const xbucket = bucket(testName)
// if (xbucket === TREATMENT) { ... }
// const x = document.querySelector(...)
// x.addEventListener('click', () => { sendSuccess(testName) })
// if (xbucket === TREATMENT) applyTreatment(x)
}
Loading