Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent internal engineering workflow from failing tests for external contributors #367

Merged
merged 6 commits into from
Oct 9, 2020
Merged

Prevent internal engineering workflow from failing tests for external contributors #367

merged 6 commits into from
Oct 9, 2020

Conversation

chiedo
Copy link
Contributor

@chiedo chiedo commented Oct 9, 2020 •
edited
Loading

Why:

Currently the .github/workflows/start-new-engineering-pr-workflow.yml does not work for external contributors. But the issue is it fails instead of practically being skipped.

What's being changed:

Adding continue-on-error should ensure this workflow shows a green check for external contributors.

Check off the following:

@chiedo chiedo requested a review from a team as a code owner October 9, 2020 20:47
@chiedo chiedo closed this Oct 9, 2020
@chiedo chiedo reopened this Oct 9, 2020
@chiedo chiedo closed this Oct 9, 2020
@chiedo chiedo reopened this Oct 9, 2020
@chiedo chiedo changed the title Prevent internal engineering workflow from failing tests by external contributors Prevent internal engineering workflow from failing tests for external contributors Oct 9, 2020
JamesMGreene
JamesMGreene approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@JamesMGreene JamesMGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe, though it sure seems like you've wrapped pretty much everything in a try-catch...? 🤔 🤷🏻‍♂️

@chiedo chiedo merged commit 6e185a0 into main Oct 9, 2020
@chiedo chiedo deleted the prevent-blocking-engineering-workflow branch October 9, 2020 21:16
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@colorado392 colorado392 mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesMGreene JamesMGreene JamesMGreene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiedo @JamesMGreene