Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move period inside ending quotation #34226

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

SeanAverS
Copy link
Contributor

Why: Move period inside ending quotation to align with style guide

Closes: #34222

What's being changed (if available, include any code snippets, screenshots, or gifs):

image

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/securing-your-account-with-two-factor-authentication-2fa/configuring-two-factor-authentication.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10
from reusable

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@SeanAverS
Copy link
Contributor Author

Hi @nguyenalex836,

I noticed #34223 also uses the same tags for the ...see "Configuring two-factor authentication using a security key" and "Configuring two-factor authentication using GitHub Mobile". part. Should I include that issue in this PR? if not then please let me know 👍

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Aug 6, 2024
@nguyenalex836
Copy link
Contributor

@SeanAverS Hello! 👋 Great catch - feel free to include update this PR to account for #34223 as well. Ping me whenever you are finished, and I'll get this merged 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Aug 6, 2024
Merged via the queue into github:main with commit e363520 Aug 6, 2024
59 checks passed
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@nguyenalex836
Copy link
Contributor

@SeanAverS Apologies - I added this PR to the merge queue and forgot to remove it 🤦 feel free to open a new PR for #34223. Thank you! 💛

@SeanAverS SeanAverS mentioned this pull request Aug 7, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team
Projects
None yet
2 participants