-
Notifications
You must be signed in to change notification settings - Fork 59.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates repo topics URL for GHES docs #34007
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@IAmHughes Thanks so much for opening a PR! I'll get this triaged for review ✨ |
title: Configuring a publishing source for your GitHub Pages site
About publishing sources{% data reusables.pages.pages-about-publishing-source %} {% data reusables.pages.private_pages_are_public_warning %} Publishing from a branch
Troubleshooting publishing from a branch{% data reusables.pages.symlink-removal %} {% data reusables.pages.admin-must-push %} If you choose the {% ifversion build-pages-with-actions %} Your {% data variables.product.prodname_pages %} site will always be deployed with a {% data variables.product.prodname_actions %} workflow run, even if you've configured your {% data variables.product.prodname_pages %} site to be built using a different CI tool. Most external CI workflows "deploy" to {% data variables.product.prodname_pages %} by committing the build output to the To find potential errors with either the build or deployment, you can check the workflow run for your {% data variables.product.prodname_pages %} site by reviewing your repository's workflow runs. For more information, see "AUTOTITLE." For more information about how to re-run the workflow in case of an error, see "AUTOTITLE." {% endif %} Publishing with a custom {% data variables.product.prodname_actions %} workflowTo configure your site to publish with {% data variables.product.prodname_actions %}: {% data reusables.pages.navigate-site-repo %}
Creating a custom {% data variables.product.prodname_actions %} workflow to publish your siteFor more information about {% data variables.product.prodname_actions %}, see "AUTOTITLE." When you configure your site to publish with {% data variables.product.prodname_actions %}, {% data variables.product.product_name %} will suggest starter workflows for common publishing scenarios. The general flow of a workflow is to:
The starter workflows use a deployment environment called {% ifversion fpt or ghec %} Note: A {% endnote %} Troubleshooting publishing with a custom {% data variables.product.prodname_actions %} workflowFor information about how to troubleshoot your {% data variables.product.prodname_actions %} workflow, see "AUTOTITLE." |
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @IAmHughes, very cool to see you again! 💖 I'm going to apply a small suggestion and then merge. ⚡
...settings-and-features/customizing-your-repository/classifying-your-repository-with-topics.md
Outdated
Show resolved
Hide resolved
...settings-and-features/customizing-your-repository/classifying-your-repository-with-topics.md
Outdated
Show resolved
Hide resolved
...settings-and-features/customizing-your-repository/classifying-your-repository-with-topics.md
Outdated
Show resolved
Hide resolved
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
GHES users shouldn't be pointed to the URL for GitHub.com topics. They should be pointed to their instance's topics list instead.
Closes: #34006
What's being changed (if available, include any code snippets, screenshots, or gifs):
I've updated the documentation to continue to link to the GitHub.com URL when on GHEC or FPT, but when on GHES it will display
https://HOSTNAME/topics
following the same nomenclature used in other documentation for GHES such as about remote repositoriesOld
New
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.