Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #33859

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Patch 1 #33859

merged 5 commits into from
Aug 15, 2024

Conversation

jaceksocha
Copy link
Contributor

Why:

Closes:

The recepie to generate JWT using bash not working when using "Client id" as "iss" , because of "Client id" is string and reqire quotes.

Result of usage token usage cause error:

{ "message": "A JSON web token could not be decoded", "documentation_url": "https://docs.github.com/rest", "status": "401" }

Example decoded payload data for JWT token generated using "Clinet id" as "iss"

"{\n \"iat\":1720435516,\n \"exp\":1720436176,\n \"iss\":Iv23liUdv*******\n}"

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • Tested locally

Copy link

welcome bot commented Jul 8, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review github apps Content related to GitHub Apps and removed triage Do not begin working on this issue until triaged by the team labels Jul 8, 2024
@nguyenalex836
Copy link
Contributor

@jaceksocha Thanks so much for opening a PR! I'll get this triaged for review ✨

@jaceksocha
Copy link
Contributor Author

Hi @nguyenalex836

To make sure (if not stuck on missing action on my side), should I take some action or simply wait patiently for review ?

Greetings

@nguyenalex836
Copy link
Contributor

@jaceksocha Hello! 👋 No action needed on your end - you'll be notified as soon as our team reviews your PR 💛 thank you for your patience!

@subatoi subatoi added the needs SME This proposal needs review from a subject matter expert label Jul 30, 2024
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836 nguyenalex836 added SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Aug 15, 2024
@nguyenalex836
Copy link
Contributor

@jaceksocha Thank you very much for your patience while our SME team reviewed your PR! Your changes look great ✨
I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Aug 15, 2024
Merged via the queue into github:main with commit 805a698 Aug 15, 2024
44 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team github apps Content related to GitHub Apps SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants