Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate that you may not be prompted to re-authenticate #33751

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Indicate that you may not be prompted to re-authenticate #33751

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b73e622
Indicate that you may not be prompted to re-authenticate
YanisaHS Jun 27, 2024
aed5ef9
Update adding-a-gpg-key-to-your-github-account.md
YanisaHS Jul 30, 2024
f393ead
Merge branch 'main' into patch-1
subatoi Jul 30, 2024
55ec29d
Merge branch 'main' into patch-1
nguyenalex836 Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...naging-commit-signature-verification/adding-a-gpg-key-to-your-github-account.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@

You can add multiple public keys to your account on {% data variables.product.product_name %}. Commits signed by any of the corresponding private keys will show as verified. If you remove a public key, any commits signed by the corresponding private key will no longer show as verified.

{% ifversion upload-expired-or-revoked-gpg-key %}

Check warning on line 29 in content/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account.md

View workflow job for this annotation

GitHub Actions / lint-content

Liquid `ifversion` (and `elsif`) should not always be true 

The Liquid ifversion condition 'upload-expired-or-revoked-gpg-key' includes all possible versions and will always be true.
To verify as many of your commits as possible, you can add expired and revoked keys. If the key meets all other verification requirements, commits that were previously signed by any of the corresponding private keys will show as verified and indicate that their signing key is expired or revoked.

![Screenshot of a list of commits. One commit is marked with a "Verified" label. Below the label, a dropdown explains that the commit was signed, but the key has now expired.](/assets/images/help/settings/gpg-verified-with-expired-key.png)

Check warning on line 32 in content/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account.md

View workflow job for this annotation

GitHub Actions / lint-content

Images alternate text should be between 40-150 characters 

Image alternate text is 172 characters long.
{% endif %}

{% data reusables.gpg.supported-gpg-key-algorithms %}
Expand All @@ -44,9 +44,9 @@
1. In the "Title" field, type a name for your GPG key.
1. In the "Key" field, paste the GPG key you copied when you [generated your GPG key](/authentication/managing-commit-signature-verification/generating-a-new-gpg-key).
1. Click **Add GPG key**.
1. To confirm the action, authenticate to your {% data variables.product.prodname_dotcom %} account.
1. If prompted, authenticate to your {% data variables.product.prodname_dotcom %} account.
YanisaHS marked this conversation as resolved.
Show resolved Hide resolved

{% ifversion upload-expired-or-revoked-gpg-key %}

Check warning on line 49 in content/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account.md

View workflow job for this annotation

GitHub Actions / lint-content

Liquid `ifversion` (and `elsif`) should not always be true 

The Liquid ifversion condition 'upload-expired-or-revoked-gpg-key' includes all possible versions and will always be true.
{% else %}

## Updating an expired GPG key
Expand Down
Loading