Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postCreate.sh doesn't execute without providing execute permission to the script first #33166

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

saikatdas0790
Copy link
Contributor

@saikatdas0790 saikatdas0790 commented May 24, 2024

Why:

Closes: #33165

What's being changed (if available, include any code snippets, screenshots, or gifs):

I modified the postCreateCommand in the devcontainer.json to also update permissions on the postCreate.sh file to add the execute permission

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented May 24, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 24, 2024
Copy link
Contributor

github-actions bot commented May 24, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/developing-in-a-codespace/rebuilding-the-container-in-a-codespace.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review Codespaces Content relating to GitHub Codespaces and removed triage Do not begin working on this issue until triaged by the team labels May 24, 2024
@nguyenalex836
Copy link
Contributor

@saikatdas0790 Thanks so much for opening a PR! I'll get this triaged for review ✨

Developer354

This comment was marked as spam.

Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saikatdas0790 - Thanks for adding this.

@hubwriter hubwriter enabled auto-merge July 22, 2024 10:18
@hubwriter hubwriter added this pull request to the merge queue Jul 22, 2024
Merged via the queue into github:main with commit f46213f Jul 22, 2024
43 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In a devcontainer, the postCreate command will not execute without being assigned the execute permission
4 participants