Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how to create a CNAME #2961

Merged
merged 9 commits into from
Feb 22, 2021
Merged

Clarify how to create a CNAME #2961

merged 9 commits into from
Feb 22, 2021

Conversation

ajs256
Copy link
Contributor

@ajs256 ajs256 commented Jan 18, 2021 •
edited
Loading

Clarify that users should create a CNAME in repo settings, rather than creating it directly.

Why:

Close issue #2184.

What's being changed:

See the diff above

Check off the following:

@ajs256
Clarify how to create a CNAME
b9e6432 
Clarify that users should create a CNAME in repo settings, rather than creating it directly. This PR closes github#2184.
lucalves
lucalves suggested changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@lucalves lucalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove code tags?

@ajs256
Copy link
Contributor Author

ajs256 commented Jan 19, 2021

Hmm. Don't know how that happened. It's fixed now!

@janiceilene
Copy link
Contributor

Thanks @ajs256! I'll get this triaged for review ✨

lucalves
lucalves approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@lucalves lucalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, is ok to me!

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Jan 19, 2021
@janiceilene janiceilene linked an issue Jan 19, 2021 that may be closed by this pull request
Update instructions in [Configuring a subdomain] help article #2184
Closed
@ajs256
Copy link
Contributor Author

ajs256 commented Jan 23, 2021

Hey there @duc811997. I would strongly advise changing your recovery codes now, since you seem to have accidentally uploaded them. @janiceilene or someone else with permissions, could you please edit their comment to remove the file?

@ajs256 ajs256 closed this Jan 23, 2021
@ajs256 ajs256 deleted the patch-2 branch January 23, 2021 23:40
@ajs256
Copy link
Contributor Author

ajs256 commented Jan 27, 2021 •
edited
Loading

Wait a minute, did I close this? I must have accidentally.

@ajs256 ajs256 restored the patch-2 branch January 27, 2021 17:38
@ajs256 ajs256 reopened this Jan 27, 2021
@janiceilene
Copy link
Contributor

Re-triaged!

adonisj910
adonisj910 suggested changes Feb 2, 2021
View reviewed changes
Copy link

@adonisj910 adonisj910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git commit

Request changes

adonisj910
adonisj910 reviewed Feb 2, 2021
View reviewed changes
Copy link

@adonisj910 adonisj910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 5, 2021
@github-actions github-actions bot closed this Feb 13, 2021
@ajs256
Copy link
Contributor Author

ajs256 commented Feb 13, 2021 •
edited
Loading

Looks like your stalebot fix isn't working...

@ajs256
Copy link
Contributor Author

ajs256 commented Feb 13, 2021

I can't re-open it, but I will not delete the branch so someone can re-open it and hopefully merge it.

@janiceilene
Copy link
Contributor

It looks like our new action inadvertently closed this 🙃 Sorry about that! Reopening and triaging this for review 💛 Thanks for not deleting the branch!

@janiceilene janiceilene reopened this Feb 16, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@chiedo chiedo added the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
felicitymay
felicitymay approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR and your patience with the technical glitches.

Your change looks good to me on our staging site: https://docs-2961--patch-2.herokuapp.com/en/github/working-with-github-pages/managing-a-custom-domain-for-your-github-pages-site#configuring-a-subdomain. It clearly fixes the linked issue ✨

@felicitymay felicitymay added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Feb 22, 2021
@felicitymay felicitymay merged commit 38cfcb7 into github:main Feb 22, 2021
@ajs256 ajs256 deleted the patch-2 branch February 22, 2021 17:10
Dmarch28 pushed a commit to Dmarch28/docs that referenced this pull request Mar 4, 2021
@ajs256 @Dmarch28
Clarify how to create a CNAME (github#2961)
9d6309c
Dmarch28 pushed a commit to Provider-of-Algorithms/docs that referenced this pull request Mar 7, 2021
@ajs256 @Dmarch28
Clarify how to create a CNAME (github#2961)
5e462e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonisj910 adonisj910 adonisj910 requested changes

@felicitymay felicitymay felicitymay approved these changes

@lucalves lucalves lucalves approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update instructions in [Configuring a subdomain] help article
6 participants
@ajs256 @janiceilene @felicitymay @lucalves @adonisj910 @chiedo