Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim pre- and post-amble in the CC-BY license text #291

Closed
wants to merge 3 commits into from

Conversation

jeffmcaffer
Copy link
Contributor

Why:

The CC-BY license file has extra text that is not intended to be part of the license itself.
See #275

closes #275

What's being changed:

Trim the extraneous text with guidance from the legal team.

@jeffmcaffer jeffmcaffer added the engineering Will involve Docs Engineering label Oct 8, 2020
@jeffmcaffer
Copy link
Contributor Author

Need to validate that the new text is properly detected by licensee. Hold off merging until validated.

Copy link
Contributor

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for working on this 👍🏼

@jeffmcaffer
Copy link
Contributor Author

Turns out that licensee does NOT detect this new text correctly. I chatted briefly with @benbalter and opened licensee/licensee#464. Two choices here:

  1. merge this now. The user experience will likely be the same in that they should still see View license and should still be guided to the LICENSE file.
  2. wait for the licensee fix.
  3. close this as won't fix. The text is not invalid, it's just "overly complete"

I have no preference one way or another.

@mlinksva
Copy link
Contributor

The repo UI isn't going to state a specific license regardless of what happens with this PR due to #204 (LICENSE-CODE is intelligible to humans, but licensee conservatively sees that and LICENSE and doesn't assert anything for the repo overall).

I would not recommend merging this. Most of the text cut is recognized to be optional, but is in the canonical version provided by CC, and in general I'd discourage fiddling with license texts merely to save a few bytes.

@jeffmcaffer
Copy link
Contributor Author

I was intending on proposing some updates to the GitHub UI that would add support for showing multiple licenses. in that case, the licensee output (having found both LICENSE and LICENSE-CODE) could be rendered usefully. The overall outcome is NOASSERTION but there is a list of high confidence licenses that could be rendered.

In any event, since currently licensee does not recognize the trimmed down text, I suggest not merging this. Once licensee does, we can reconsider.

@chiedo
Copy link
Contributor

chiedo commented Oct 19, 2020

In any event, since currently licensee does not recognize the trimmed down text, I suggest not merging this. Once licensee does, we can reconsider.

Sold!

@chiedo chiedo closed this Oct 19, 2020
@chiedo chiedo deleted the jeffmcaffer-patch-1 branch November 30, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new LICENSE file incorrect, and would not be detected by github
4 participants