-
Notifications
You must be signed in to change notification settings - Fork 61.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim pre- and post-amble in the CC-BY license text #291
Conversation
Need to validate that the new text is properly detected by licensee. Hold off merging until validated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for working on this 👍🏼
Turns out that licensee does NOT detect this new text correctly. I chatted briefly with @benbalter and opened licensee/licensee#464. Two choices here:
I have no preference one way or another. |
The repo UI isn't going to state a specific license regardless of what happens with this PR due to #204 ( I would not recommend merging this. Most of the text cut is recognized to be optional, but is in the canonical version provided by CC, and in general I'd discourage fiddling with license texts merely to save a few bytes. |
I was intending on proposing some updates to the GitHub UI that would add support for showing multiple licenses. in that case, the licensee output (having found both LICENSE and LICENSE-CODE) could be rendered usefully. The overall outcome is NOASSERTION but there is a list of high confidence licenses that could be rendered. In any event, since currently licensee does not recognize the trimmed down text, I suggest not merging this. Once licensee does, we can reconsider. |
Sold! |
Why:
The CC-BY license file has extra text that is not intended to be part of the license itself.
See #275
closes #275
What's being changed:
Trim the extraneous text with guidance from the legal team.