Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code block markdown in gradle packages doc #264

Conversation

yutailang0119
Copy link

@yutailang0119 yutailang0119 commented Oct 8, 2020

Why:

I find code block markdown break in Configuring Gradle for use with GitHub Packages

What's being changed:

before after
image image

Check off the following:

@welcome
Copy link

welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@yutailang0119 yutailang0119 force-pushed the fix-markdown-configuring-gradle-for-use-with-github-packages branch from 589c69a to 658944c Compare October 8, 2020 12:17
@yutailang0119 yutailang0119 force-pushed the fix-markdown-configuring-gradle-for-use-with-github-packages branch from 658944c to a4e28a5 Compare October 8, 2020 12:29
@runleonarun
Copy link
Contributor

Hello @yutailang0119! Thank you for proposing a pull request for fixing this problem. We are overjoyed by the help we've been receiving from the community. 💟

Because this particular issue has been fixed by the GitHub Docs team, I am going to close this pull request. We encourage folks to open an issue first so we can verify the need for the proposed change and avoid duplicate work.

@runleonarun runleonarun closed this Oct 8, 2020
@yutailang0119
Copy link
Author

Thank you for comment!
I confirmed that it was fixed with #273 .
Thanks! ✨

@yutailang0119 yutailang0119 deleted the fix-markdown-configuring-gradle-for-use-with-github-packages branch October 9, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants