Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyperlink to pull_request_target #25479

Merged
merged 3 commits into from
May 11, 2023
Merged

Hyperlink to pull_request_target #25479

merged 3 commits into from
May 11, 2023

Conversation

jeffwidman
Copy link
Member

Why:

While reading this doc, I had a question about this event, so a deeplink would have been convenient.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@jeffwidman
Hyperlink to pull_request_target
75f4a44 
While reading this doc, I had a question about this event, so a deeplink would have been convenient.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 9, 2023
@cmwilson21
Copy link
Contributor

👋 @jeffwidman Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels May 10, 2023
@jeffwidman @peterbe
Update data/reusables/actions/workflow-run-approve-public-fork.md
353d596 
Co-authored-by: Peter Bengtsson <peterbe@github.com>
skedwards88
skedwards88 previously approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this! I'm going to incorporate a change for the style guide, then I'll merge this down for you.

data/reusables/actions/workflow-run-approve-public-fork.md Outdated Show resolved Hide resolved
@skedwards88 skedwards88 enabled auto-merge May 11, 2023 21:34
@skedwards88 skedwards88 added this pull request to the merge queue May 11, 2023
Merged via the queue into github:main with commit 0288552 May 11, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@jeffwidman jeffwidman deleted the patch-3 branch July 6, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbe peterbe peterbe left review comments

@skedwards88 skedwards88 skedwards88 approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffwidman @cmwilson21 @peterbe @skedwards88