-
Notifications
You must be signed in to change notification settings - Fork 61.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional cleanup step after failover to HA replica #252
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Thanks for opening a PR @mwiesen! I'll let the @github/docs-content-core team know it's ready for review 💝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion to ensure that the example command appears in full, otherwise the change looks great 💖
content/admin/enterprise-management/initiating-a-failover-to-your-replica-appliance.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to merge once the formatting of the example command is fixed 😄
Hi @mwiesen - I'm not sure if you saw my comment on this pull request. From your really clear description of the problem this change addresses, I'm keen to resolve the problem so that we can merge this PR and your improvement to the docs will be live. If don't hear from you before Monday, October 26, I'll commit my fix and merge this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting that @felicitymay !
…our-replica-appliance.md Co-authored-by: Felicity Chapman <felicitymay@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated from |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
``` | ||
- On the new primary, remove the UUIDs using `ghe-repl-teardown`. Please replace *`UUID`* with a UUID you retrieved in the previous step. | ||
```shell | ||
$ ghe-repl-teardown -u <em>UUNID</em> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/UUNID/UUID/
small typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm not sure why this only just popped up in my notifications given it was merged a month ago. I'll open a new PR to fix the typo.
Why:
With the current documentation a failover will be completed and access to the GitHub Enterprise Server will be restored, however a configuration cleanup will not be performed.
This means that Spokes, DPages, and Storage will maintain references to the old (potentially inaccessible) servers yet will be unable to replicate any data to them. This can and will eventually lead to clone/push failures and full repository outages should those servers not be re-added as replicas.
Solves https://github.com/github/docs-content/issues/2564
What's being changed:
Our current documentation outlines the high-level steps to perform a failover, however more detail is needed clarifying follow-up actions in the event that that the primary server and/or other replicas will not be re-added to the GitHub Enterprise Server configuration.
I added a new (optional) step following the current step 7 noting the UUIDs of any servers which will not be re-added to the environment should be cleaned up by running
ghe-repl-teardown -u <uuid_here>
.Check off the following:
@maclarel
@myarb