-
Notifications
You must be signed in to change notification settings - Fork 60.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setting-up-your-development-environment-to-create-a-github-app.md #25061
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@edward Thanks for submitting a PR! We appreciate the fix. I do have a couple suggestions. I agree, the start of that paragraph should be "Authenticating as a GitHub App", but we try to avoid in-line links per our style guide. That's why the
I think this will help the article flow better. Thanks again for pointing this out and opening a PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix! We'll get this merged down for you. Apologies: I missed @cmwilson21 's comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: 🙈 I missed that @cmwilson21 had already reviewed this, but I agree with her ideas for improvement.
...reating-github-apps/guides/setting-up-your-development-environment-to-create-a-github-app.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
….md (github#25061) Co-authored-by: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com>
Why:
Fixes up a link in https://docs.github.com/en/apps/creating-github-apps/guides/setting-up-your-development-environment-to-create-a-github-app#step-5-review-the-github-app-template-code :
is now “Authenticating as a GitHub App”.
Check off the following: