Actions github context: Move github.event_name up to other .event* entries #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @Simran-B Thank you for proposing this change! While it is a great suggestion, we decided to go with sorting the table alphabetically, so hopefully, others will have an easier time finding those properties. I am going to close this pull request in favor of this one, but I look forward to your future contributions! ✨ |
|
Alright, I appreciate the solution. The first paragraph of #121 is in fact taken from a support ticket that I submitted 😄👍 |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
This was referenced Apr 2, 2021
This was referenced Apr 9, 2021
This was referenced Apr 20, 2021
This was referenced Apr 27, 2021
This was referenced Jun 6, 2021
This was referenced Jun 14, 2021
This was referenced Jul 5, 2021
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
* remove test meta * remove speech output * include more approved links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
While it makes perfect sense to not sort tables alphabetically, but have rows in a pedagogically meaningful order, it strikes me as an oversight that
github.event_nameisn't adjacent to the other two closely related entries. I actually missed it when I looked for a way to access the type of event because of the row order.What's being changed:
Move a row of the Actions github context table up.
Check off the following:
All of the tests are passing.I have reviewed my changes in staging.