Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui update support buttons #248

Merged
merged 2 commits into from
Oct 8, 2020
Merged

ui update support buttons #248

merged 2 commits into from
Oct 8, 2020

Conversation

Arhell
Copy link
Contributor

@Arhell Arhell commented Oct 8, 2020 •
edited
Loading

Why:

Fixes #237 . button position

What's being changed:

before in issue #237
After fix
2
3

Check off the following:

Review page

cc @github/docs-engineering

@welcome
Copy link

welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

dwarkeshkaswala
dwarkeshkaswala approved these changes Oct 8, 2020
View reviewed changes
Copy link

@dwarkeshkaswala dwarkeshkaswala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed ✅

JasonEtco
JasonEtco approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the fix @Arhell!! ✨

@JasonEtco JasonEtco merged commit 3d05341 into github:main Oct 8, 2020
@chiedo chiedo added the engineering Will involve Docs Engineering label Oct 8, 2020
@Arhell Arhell deleted the ui-button-upd branch October 8, 2020 15:06
@chiedo chiedo mentioned this pull request Oct 8, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 23, 2023
Open
This was referenced Apr 11, 2023
Open
Open
Open
Open
@Mdbabul41 Mdbabul41 mentioned this pull request Apr 11, 2023
Open
@alenuyee alenuyee mentioned this pull request Apr 11, 2023
Open
@ghostfacepenetration ghostfacepenetration mentioned this pull request Apr 12, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2023
Open
@Aknc34 Aknc34 mentioned this pull request Apr 12, 2023
Open
@weber2017 weber2017 mentioned this pull request Apr 12, 2023
Open
@lilmoonlil lilmoonlil mentioned this pull request Apr 12, 2023
Open
This was referenced Apr 12, 2023
Open
Open
Open
Open
Open
Open
@eliasbuchwald eliasbuchwald mentioned this pull request Apr 24, 2023
Open
@ayvazjet ayvazjet mentioned this pull request Apr 24, 2023
Open
This was referenced Apr 24, 2023
Open
Open
@kabat87 kabat87 mentioned this pull request Apr 25, 2023
Open
@qmutz qmutz mentioned this pull request Apr 25, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 25, 2023
Open
@mmoohhkanahmady mmoohhkanahmady mentioned this pull request Apr 25, 2023
Open
This was referenced Apr 25, 2023
Open
Open
@Mhienahm Mhienahm mentioned this pull request Apr 25, 2023
Open
@markymark888 markymark888 mentioned this pull request Apr 25, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 25, 2023
Open
@Visva92 Visva92 mentioned this pull request Apr 25, 2023
Open
@Burkay5441 Burkay5441 mentioned this pull request Apr 25, 2023
Open
@lahung1992 lahung1992 mentioned this pull request Apr 25, 2023
Open
@irinaqwerty852 irinaqwerty852 mentioned this pull request Apr 25, 2023
Open
@dmvol81 dmvol81 mentioned this pull request Apr 25, 2023
Open
@Qdigital Qdigital mentioned this pull request Apr 25, 2023
Open
@RiyadhAsaameai RiyadhAsaameai mentioned this pull request Apr 25, 2023
Open
This was referenced Apr 26, 2023
Open
Open
Open
@Shadow666gamer Shadow666gamer mentioned this pull request Jul 16, 2023
Merged
@lilmoonlil lilmoonlil mentioned this pull request Jul 29, 2023
Open
This was referenced Aug 8, 2023
Open
Open
@juwan-crypto juwan-crypto mentioned this pull request Oct 12, 2023
Open
@lilmoonlil lilmoonlil mentioned this pull request Oct 17, 2023
Open
@avengerfart avengerfart mentioned this pull request Dec 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonEtco JasonEtco JasonEtco approved these changes

@dwarkeshkaswala dwarkeshkaswala dwarkeshkaswala approved these changes

Assignees
No one assigned
Labels
engineering Will involve Docs Engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: contact support banner needs an alignment
4 participants
@Arhell @JasonEtco @dwarkeshkaswala @chiedo