-
Notifications
You must be signed in to change notification settings - Fork 61.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove all-contributors suggestion from merge notification #225
remove all-contributors suggestion from merge notification #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @zeke 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Co-authored-by: Janice <janiceilene@github.com>
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
@JasonEtco Thanks for the fix. I do wonder about removing the instructions though. Seems like there's a fair bit of friction without it. Users will have to follow the link, figure out the syntax, pick an emoji (do we care what they pick?) and then add the comment. They'll also need to remember to do that for each different type of contribution. Is it possible to do one of
|
Thanks for that feedback @jeffmcaffer!
We can make a best guess, but this gets a little nuanced when we want to tag the right kind of contribution (
That's what we tried to do, but it seems like the bot is too aggressive in its comment parsing 😅 any comment that mentioned the bot is parsed, and if it fails the bot comments anyway. If we were to write a comment without mentioning the bot, it wouldn't be a copy-pastable example. I'm interested in @janiceilene's thoughts here too - happy to keep experimenting with this! |
I did a quick look at the project (https://github.com/all-contributors/all-contributors) and didn't see anything detailing how to include instructions in a PR (i.e., quoting). I wonder if they've encountered this scenario? (didn't see anything obvious in the issues). Question, does GitHub have a way of quoting at mentions in its markup? Like if I want to say "mention me, @jeffmcaffer" in a comment without actually mentioning me, how would I do that? |
* File setup * Add original content * Edit content * Update timescale-cloud/user-management.md * Apply suggestions from code review Co-authored-by: Ryan Booz <ryan@timescale.com> Co-authored-by: Ryan Booz <ryan@timescale.com>
This PR removes the bit about using the all-contributors bot from the "you merged a PR" workflow.
Resolves #218
Resolves #220
cc @github/docs-engineering