-
Notifications
You must be signed in to change notification settings - Fork 60.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dart to dependency scope table #22019
Conversation
👋 @AAugustine Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AAugustine 👋🏻 - this LGTM ✨
Inquired with you privately about versioning. Happy to merge this once we've established that there are no versioning considerations that we need to add 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the relevant versioning to the two new rows.
Will test this on staging before merging.
data/reusables/dependabot/dependabot-alerts-dependency-scope.md
Outdated
Show resolved
Hide resolved
data/reusables/dependabot/dependabot-alerts-dependency-scope.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💖
Thanks for double-checking the versioning for me 🙇🏻
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes https://github.com/github/docs-content/issues/8691
Closes https://github.com/github/dependabot-alerts/issues/851
What's being changed (if available, include any code snippets, screenshots, or gifs):
Table located at:
data/reusables/dependabot/dependabot-alerts-dependency-scope.md
is being changed to include DartCheck off the following: