Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow-commands-for-github-actions.md #216

Merged
merged 2 commits into from
Oct 10, 2020

Conversation

paulyhedral
Copy link
Contributor

@paulyhedral paulyhedral commented Oct 7, 2020

While a meter for delis would be incredibly useful for determining the best sandwich shop, a delimiter is better for dividing multiline strings.

Why:

Correcting misspelling in text.

What's being changed:

Spelling changed from delimeter to delimiter.

Check off the following:

While a meter for delis would be incredibly useful for determining the best sandwich shop, a delimiter is better for dividing multiline strings.
@welcome
Copy link

welcome bot commented Oct 7, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks for opening this up @paulyhedral 🥪 Could you fill out the pull request template and then I'll get this up for review!

@paulyhedral
Copy link
Contributor Author

Filled in remainder of pull request template.

@janiceilene
Copy link
Contributor

Thanks @paulyhedral 💛 I'll let the @github/docs-content-ecosystem team know this is ready for review!

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 9, 2020
Copy link
Contributor

@rachmari rachmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulyhedral Deli meter 😆 👏 I did laugh out loud when reading this so thank you for that, but also thank you for finding this one and fixing it up! 💚 :octocat:

I'll get this merged!! 🚢 🚀

@rachmari rachmari self-assigned this Oct 10, 2020
@rachmari rachmari merged commit b25f81e into github:main Oct 10, 2020
@janiceilene
Copy link
Contributor

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@paulyhedral
Copy link
Contributor Author

@all-contributors please add @paulyhedral for content

@allcontributors
Copy link
Contributor

@paulyhedral

I've put up a pull request to add @paulyhedral! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants