Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wrong Issue_comment link #2030

Merged
merged 4 commits into from
Dec 16, 2020
Merged

Update wrong Issue_comment link #2030

merged 4 commits into from
Dec 16, 2020

Conversation

Ashok314
Copy link
Contributor

@Ashok314 Ashok314 commented Dec 12, 2020

Link redirecting to the different page was fixed to the correct one.

Why:

Fixed the wrong link as described in issue "Update issue_comment link in GitHub Actions docs #2019".

What's being changed:

In file, https://github.com/github/docs/blob/main/content/actions/reference/events-that-trigger-workflows.md: line# 314, Link is updated with the correct directory.

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

Link redirecting to the different page was fixed to the correct one.
@welcome
Copy link

welcome bot commented Dec 12, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@ghost ghost mentioned this pull request Dec 12, 2020
4 tasks
@janiceilene janiceilene linked an issue Dec 14, 2020 that may be closed by this pull request
1 task
@janiceilene
Copy link
Contributor

@Ashok314 Thank you so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Dec 14, 2020
Copy link
Contributor

@jmarlena jmarlena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to ship!

@jmarlena jmarlena merged commit 442b3fe into github:main Dec 16, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update issue_comment link in GitHub Actions docs
4 participants