Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GITHUB_{HEAD|BASE}_REF env var descriptions #1955

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

lucascosti
Copy link
Contributor

@lucascosti lucascosti commented Dec 10, 2020

Why:

Closes: #673

The description of the GITHUB_HEAD_REF and GITHUB_BASE_REF GitHub Actions environment variables are incorrect. I have confirmed with engineering that these are set for every pull request event, and not just forks.

What's being changed:

Fixed the descriptions to state that they apply to all PR events.

Staged preview: https://docs-1955--lucascostiactions-p.herokuapp.com/en/free-pro-team@latest/actions/reference/environment-variables#default-environment-variables

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@lucascosti
Copy link
Contributor Author

closing and reopening to try to fix the heroku deploy....

@lucascosti lucascosti closed this Dec 10, 2020
@lucascosti lucascosti reopened this Dec 10, 2020
@lucascosti lucascosti mentioned this pull request Dec 10, 2020
4 tasks
Copy link
Contributor

@martin389 martin389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @lucascosti 🎸

@lucascosti lucascosti merged commit d7ccef7 into main Dec 15, 2020
@lucascosti lucascosti deleted the lucascosti/actions-pr-env-vars branch December 15, 2020 06:46
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is GITHUB_BASE_REF and GITHUB_HEAD_REF set for PRs in non-forked repositories?
3 participants