-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add necessary bits to install and enable copilot. #18833
Conversation
No need to send users down the rabbit hole of how many legacy ways to install vim plugins... Simply direct them to use the new builtin nvim plugin support.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
Is the failing test working properly? I forked the docs repo to create a pull request which does not contain any new repo reference and my fork is public https://github.com/georgalis/docs yet,
what |
adjust referenced repo from ``` https://github.com/github/copilot.vim.git ``` to ``` https://github.com/github/copilot.vim ``` I'm not sure this makes a difference with regard to `private repositories` if not, perhaps the test should check PUBLIC_REPOS with .git as valid.
@georgalis Thanks so much for opening a PR! I'll get this triaged for review ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't even realize nvim has a built in plugin manager. I think most folks use other plugin managers, but this looks correct.
It might be worth saying something like "use your plugin manager to install copilot or to use the built in plugin manager", as I was super confused at first.
@djensenius @janiceilene just curious, this documentation fixup, and revision per feedback, has been open over 5 weeks? seems a long time for low hanging fruit? |
@georgalis Thanks for checking in on this one. Your PR is on the board and waiting for review. A writer will get eyes on it soon. 👀 We appreciate your patience as we catch up on the summer backlog. 💛 |
Hi @georgalis 👋🏻 I've made a couple of small changes to simplify the language and apply the changes across all 3 operating systems. I've got a follow up PR for the
Which will then be followed by your updated installation step:
If that sounds okay to you, I'll go ahead and get those changes merged? |
Hi @jules-p that explicitly reverts the key language of my change. Neovim has a built in plugin manager. Keep it simple, use that, and indicate alternate managers will also work if they are preferred. If you suggest a 3rd party plugin manager first, anyone that doesn't know how to use one already will research and find a ton of options and began an evaluation process. Which one is best? How best to implement? All the integration options don't help new users. Fine to keep that door open but there is no reason to send new users down that road. The neovim solves the world of vim plugin manages with a built in one. There is no need to introduce new copilot users to legacy plugin manager options of vim. Guide new users onto the simple path. If they want a different plugin manager, let it be their prerogative. |
Hi @georgalis, I see what you're saying. I'm happy to highlight the built-in plug-in manager first, although I don't think we want to entirely obscure the other paths. Would something like this 👇🏻 address your concerns? |
…arted-with-github-copilot-in-neovim.md
...copilot/getting-started-with-github-copilot/getting-started-with-github-copilot-in-neovim.md
Outdated
Show resolved
Hide resolved
…arted-with-github-copilot-in-neovim.md
...copilot/getting-started-with-github-copilot/getting-started-with-github-copilot-in-neovim.md
Outdated
Show resolved
Hide resolved
…arted-with-github-copilot-in-neovim.md
...copilot/getting-started-with-github-copilot/getting-started-with-github-copilot-in-neovim.md
Outdated
Show resolved
Hide resolved
…arted-with-github-copilot-in-neovim.md
Hi @georgalis, I've commited the necessary changes, except for the updates to the
If you look at the article in staging you'll see that it has automatically detected the code block, and the fence posts are not required in this instance. |
Hi @jules-p, thanks for clearing that up. Hopefully this refactor will cover all the bases. In the macro you asked about, I removed specific plugin managers (search for |
git clone https://github.com/github/copilot.vim \ | ||
~/.config/PATH/TO/YOUR/NEOVIM/CONFIG/FILE/copilot.vim | ||
1. To configure {% data variables.product.prodname_copilot %}, open Neovim and enter the following command. | ||
mkdir -p ~/.config/nvim/pack/github/start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git clone
does an implicit mkdir -p
, so this command is unnecessary.
git clone https://github.com/github/copilot.vim \ | ||
~/.config/nvim/pack/github/start/copilot.vim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct path on Windows is ~/AppData/Local/nvim/pack/github/start/copilot.vim
. Unfortunately it's not quite a drop-in replacement, as ~
and \
are specific to UNIX shells. In the copilot.vim README, I'm currently suggesting the following PowerShell command:
git clone https://github.com/github/copilot.vim.git `
$HOME/AppData/Local/nvim/pack/github/start/copilot.vim
I'd be remiss not to point out most users do not consider plugin managers to be legacy. They handle a lot more than the Neovim built-in—namely installation and upgrading—and indeed some of them were created after the built-in support was added. But I think the one sentence acknowledgement here is sufficient. Note that since the creation of this PR, copilot.vim gained support for vanilla Vim in addition to Vim, and that necessitates the use of different installation paths. But I wouldn't let that delay shipping this; we can circle back on that later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that works, it's fine with me.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
No need to send users down the rabbit hole of how many legacy ways to install vim plugins... Simply direct them to use the new builtin nvim plugin support.
Why:
Closes 19579
What's being changed (if available, include any code snippets, screenshots, or gifs):
add necessary steps to docs
Check off the following:
Writer impact (This section is for GitHub staff members only):