Fix output variable name for composite action example (random-id vs random-number)

[parroty]

Why:

Hi 👋 . There seems to be an inconsistency in variable names (between random-id and random-number) after the following PR was merged.

• fixes wrong ::set-output name #17059

The above change did not update the random-id in the outputs section, which results in an empty random value output (the example is not working as expected).

Corresponding Code Snippet

• https://docs.github.com/en/actions/creating-actions/creating-a-composite-action#creating-an-action-metadata-file

name: 'Hello World'
description: 'Greet someone'
inputs:
  who-to-greet:  # id of input
    description: 'Who to greet'
    required: true
    default: 'World'
outputs:
  random-number:
    description: "Random number"
    value: ${{ steps.random-number-generator.outputs.random-id }}
runs:
  using: "composite"
  steps:
    - run: echo Hello ${{ inputs.who-to-greet }}.
      shell: bash
    - id: random-number-generator
      run: echo "::set-output name=random-number::$(echo $RANDOM)"
      shell: bash
    - run: echo "${{ github.action_path }}" >> $GITHUB_PATH
      shell: bash          
    - run: goodbye.sh
      shell: bash

What's being changed:

This PR intends to update the random-id with random-number in the outputs section.
(Another option would be to revert the #17059, but this PR is for moving forward with unifying the variable name).

The followings are the testing results from my private repository.

Before Change

• https://github.com/parroty/hello-world-composite-action/blob/main/.github/actions/greeter-not-good/action.yml#L11
• https://github.com/parroty/hello-world-composite-action/runs/6223312049?check_suite_focus=true

After Change

• https://github.com/parroty/hello-world-composite-action/blob/main/.github/actions/greeter-good/action.yml#L11
• https://github.com/parroty/hello-world-composite-action/runs/6223311990?check_suite_focus=true

Check off the following:

• I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
• For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

• This pull request impacts the contribution experience
  • I have added the 'writer impact' label
  • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

[welcome]

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

[github-actions]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

---

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source	Preview	Production	What Changed
actions/creating-actions/creating-a-composite-action.md	fpt ghes@ 3.4 3.3 3.2 3.1 ghae ghec	fpt ghes@ 3.4 3.3 3.2 3.1 ghae ghec

[github-actions]

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

[ramyaparimi]

Related PR #17464

[github-actions]

This is a gentle bump for the docs team that this PR is waiting for technical review.

[ethomson]

Good catch. Thanks @parroty !

[ramyaparimi]

@parroty
Thanks so much for opening a PR with this fix! I'll get this merged once tests are passing 🍏

[github-actions]

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡