Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style guide fixes to linking-a-pull-request-to-an-issue.md #17427

Merged
merged 3 commits into from
May 12, 2022
Merged

Style guide fixes to linking-a-pull-request-to-an-issue.md #17427

merged 3 commits into from
May 12, 2022

Conversation

Rick-Anderson
Copy link
Contributor

Per MS style guide and many other style guides, avoid:

  • Please except in situations where the customer is asked to do something inconvenient or the application or site is to blame for the situation.
  • Future tense.
  • Parenthetical clauses.

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@Rick-Anderson
Update linking-a-pull-request-to-an-issue.md
827e037 
Per MS style guide and many other style guides, avoid:

* Please except in situations where the customer is asked to do something inconvenient or the application or site is to blame for the situation.
* Future tense.
* Parenthetical clauses.
@welcome
Copy link

welcome bot commented Apr 27, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
 fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae

@Rick-Anderson Rick-Anderson changed the title Update linking-a-pull-request-to-an-issue.md Style guide fixes to linking-a-pull-request-to-an-issue.md Apr 27, 2022
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review issues Content related to issues and removed triage Do not begin working on this issue until triaged by the team labels Apr 28, 2022
@ramyaparimi
Copy link
Contributor

@Rick-Anderson
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@mchammer01 mchammer01 self-requested a review May 12, 2022 09:27
mchammer01
mchammer01 reviewed May 12, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rick-Anderson 👋🏻 - This LGTM ✨
Just making a minor suggestion that I'm going to apply.

content/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue.md Outdated Show resolved Hide resolved
@mchammer01
Copy link
Contributor

I'm going to try and merge this but previews aren't currently working 🤷🏻

mchammer01
mchammer01 approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to ship :shipit:

@mchammer01 mchammer01 merged commit 77eaa6f into github:main May 12, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@Woodpile37 Woodpile37 mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team issues Content related to issues waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rick-Anderson @ramyaparimi @mchammer01