Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant mention of "Allow edits from maintainers" setting from intro #17127

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Remove redundant mention of "Allow edits from maintainers" setting from intro #17127

merged 2 commits into from
Apr 18, 2022

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Apr 16, 2022 •
edited
Loading

Why:

The very first sentence of the introductory paragraph of the "Creating a pull request from a fork" page is about an "Allow edits from maintainers" setting that will only be available after step 5 of the instructions.

This setting is already well explained at the appropriate place in the instructions. Mentioning it redundantly at the very start of the document is confusing and makes it less approachable to the target reader.

What's being changed:

Remove the redundant mention of the "Allow edits from maintainers" setting from the introductory paragraph of the page.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@per1234
Remove redundant mention of "Allow edits from maintainers" setting fr…
a99482b 
…om intro

The very first sentence of the introductory paragraph of the "Creating a pull request from a fork" page is about a "Allow edits from maintainers" setting that will only be available after step 5 of the instructions.

This setting is already well explained at the appropriate place in the instructions. Mentioning it redundantly at the very start of the document is confusing and makes it less approachable to the target reader.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork.md Modified Original

@Successfulcryptokid

This comment was marked as spam.

Sign in to view
@ramyaparimi ramyaparimi added pull requests Content related to pull requests content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 18, 2022
@ramyaparimi
Copy link
Contributor

@per1234
Thanks so much for opening a PR! I'll get this triaged for review ⚡

lecoursen
lecoursen approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@lecoursen lecoursen added the ready to merge This pull request is ready to merge label Apr 18, 2022
@lecoursen lecoursen enabled auto-merge April 18, 2022 14:13
@lecoursen lecoursen merged commit 226fae6 into github:main Apr 18, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@per1234 per1234 deleted the clean-fork-pr-intro branch April 18, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecoursen lecoursen lecoursen approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team pull requests Content related to pull requests ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@per1234 @Successfulcryptokid @ramyaparimi @lecoursen