Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing explanation related to the --disableupdate #16802

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

nikola-jokic
Copy link
Contributor

Why:

The documentation states that you should pass --disableupdate during the run.sh, but it will throw a warning after the runner PR is merged. --disableupdate flag should be passed during the registration phase.

Closes #16801

What's being changed:

Explanation and example when you should pass the --disableupdate

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/hosting-your-own-runners/autoscaling-with-self-hosted-runners.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert and removed triage Do not begin working on this issue until triaged by the team labels Apr 4, 2022
@ramyaparimi
Copy link
Contributor

@nikola-jokic Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

thboop
thboop previously approved these changes Apr 6, 2022
Copy link
Contributor

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 . As a maintainer of the actions/runner I can say this is correct from a technical standpoint, but would love if someone on the docs team could review the verbiage and get this merged whenever it is convenient for y'all.

ethomson
ethomson previously approved these changes Apr 6, 2022
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition! I made some minor style suggestions that I will go ahead and incorporate, then we'll get this merged down for you.

@skedwards88 skedwards88 dismissed stale reviews from ethomson and thboop via b5e57c7 April 6, 2022 18:04
@skedwards88 skedwards88 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Apr 6, 2022
@skedwards88 skedwards88 enabled auto-merge (squash) April 6, 2022 18:05
@skedwards88 skedwards88 merged commit d2ae098 into github:main Apr 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@nikola-jokic nikola-jokic deleted the patch-3 branch April 6, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-hosted runners --disableupdate should be passed during registering phase
5 participants