-
Notifications
You must be signed in to change notification settings - Fork 59.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing explanation related to the --disableupdate #16802
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
@nikola-jokic Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋 . As a maintainer of the actions/runner
I can say this is correct from a technical standpoint, but would love if someone on the docs team could review the verbiage and get this merged whenever it is convenient for y'all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this addition! I made some minor style suggestions that I will go ahead and incorporate, then we'll get this merged down for you.
content/actions/hosting-your-own-runners/autoscaling-with-self-hosted-runners.md
Outdated
Show resolved
Hide resolved
content/actions/hosting-your-own-runners/autoscaling-with-self-hosted-runners.md
Outdated
Show resolved
Hide resolved
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
The documentation states that you should pass
--disableupdate
during therun.sh
, but it will throw a warning after the runner PR is merged.--disableupdate
flag should be passed during the registration phase.Closes #16801
What's being changed:
Explanation and example when you should pass the
--disableupdate
Check off the following:
Writer impact (This section is for GitHub staff members only):