Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GITHUB.SHA and GITHUB.REF for repository_dispatch #1493

Merged
merged 4 commits into from
Dec 14, 2020
Merged

Fix GITHUB.SHA and GITHUB.REF for repository_dispatch #1493

merged 4 commits into from
Dec 14, 2020

Conversation

ba32107
Copy link
Contributor

@ba32107 ba32107 commented Nov 20, 2020 •
edited
Loading

Why:

Fixes #1494

What's being changed:

I've changed the GITHUB.SHA and GITHUB.REF values to refer to the default branch.

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@ba32107
Fix GITHUB.SHA and GITHUB.REF for repository_dispatch
c26119e 
I'm fairly sure the `repository_dispatch` event always happens for the default branch. This presumption is confirmed by the fact that the `reusables.github-actions.branch-requirement` note is present for this event.

I think this was a copy-paste error from `workflow_dispatch`.
@welcome
Copy link

welcome bot commented Nov 20, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@ba32107 ba32107 marked this pull request as ready for review November 20, 2020 10:36
@janiceilene
Copy link
Contributor

@ba32107 Thanks so much for opening a PR! I'll get this triaged for review 💖

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 20, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 28, 2020
@ba32107
Copy link
Contributor Author

ba32107 commented Nov 28, 2020

Hi @janiceilene, just commenting so the PR doesn't go stale. Any chance this could be reviewed? Thanks.

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Nov 29, 2020
@janiceilene
Copy link
Contributor

@ba32107 Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 9, 2020
@ba32107
Copy link
Contributor Author

ba32107 commented Dec 9, 2020

Bump

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 9, 2020
@lucascosti lucascosti self-assigned this Dec 14, 2020
lucascosti
lucascosti approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, @ba32107! Yep, I believe you are right, I'll get this merged! 🚀

@lucascosti lucascosti merged commit 6da68ce into github:main Dec 14, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@ba32107 ba32107 deleted the patch-1 branch December 14, 2020 06:54
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@ggodeke @charislam @Loquacity
Update maintenance.md (github#1493)
0feaf02 
* Update maintenance.md

Add status page and tip to apply changes early

* Apply suggestions from code review

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucascosti lucascosti lucascosti approved these changes

Assignees

@lucascosti lucascosti

Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"repository_dispatch" event shows wrong GITHUB.SHA and GITHUB.REF information
3 participants
@ba32107 @janiceilene @lucascosti