Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation issue no #1034 #1242

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Improve documentation issue no #1034 #1242

merged 2 commits into from
Dec 2, 2020

Conversation

StarTrooper08
Copy link
Contributor

@StarTrooper08 StarTrooper08 commented Nov 10, 2020 •
edited
Loading

Done with the minor fixes for open issue number #1034 .

Why:

What's being changed:

Check off the following:

@StarTrooper08
Improve documentation issue no github#1034
1fc2f0c 
Done with the minor fixes for open issue number github#1034 .
@welcome
Copy link

welcome bot commented Nov 10, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@nschonni
Copy link
Contributor

nschonni commented Nov 10, 2020 •
edited
Loading

👍 might be better to wrap the individual keys in <kbd> and keep the + separately in-between as text

@janiceilene
Copy link
Contributor

Thanks so much @StarTrooper08! I'll triage this for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 10, 2020
@StarTrooper08
Copy link
Contributor Author

StarTrooper08 commented Nov 10, 2020 •
edited
Loading

That was a nice experience working with you 😊.

@StarTrooper08
Copy link
Contributor Author

StarTrooper08 commented Nov 16, 2020 •
edited
Loading

@janiceilene is there any new issue in GitHub docs that I can solve. Please suggest . Thank you.

@janiceilene
Copy link
Contributor

@StarTrooper08 You can check out issues with a "help wanted" label ⚡

@StarTrooper08
Copy link
Contributor Author

Ok thank you ☺️

@snyk-bot snyk-bot mentioned this pull request Nov 19, 2020
Open
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 26, 2020
@StarTrooper08
Copy link
Contributor Author

Can someone please review by work .
If some issues are still there with issue no #1034 . Please let me know.

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Nov 28, 2020
@janiceilene
Copy link
Contributor

@StarTrooper08 This is definitely not stale! Thanks for your patience 💛 Our small team is working our way through reviewing all of the amazing contributions ✨

megbird
megbird approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great! Thank you so much for your patience in getting a review 💛 I'll merge this in now 🚢 🎉

@megbird megbird merged commit af12121 into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@cadamini cadamini mentioned this pull request Mar 3, 2021
Closed
@PrapatsaraNaksuth PrapatsaraNaksuth mentioned this pull request Mar 14, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 24, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 10, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jun 14, 2021
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 16, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Dec 31, 2021
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 4, 2022
Merged
@snyk-bot snyk-bot mentioned this pull request May 14, 2022
Merged
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Jun 3, 2022
Open
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
@ayvazjet ayvazjet mentioned this pull request Sep 27, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 28, 2022
Open
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@Loquacity @charislam
Move Updating How To to new template (github#1242)
0e17abb 
* fix typo in index

* temp file movements

* Index and About

* Major upgrade

* Minor updates

* Downrgade

* Upgrade pg

* small edits

* reflow

* filenames

* folder name

* Docker

* page index

* link fixes

* typo

* More "updates"

* review all reference links

* Make vale happier

* Apply suggestions from code review

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@Loquacity
Revert "Move Updating How To to new template (github#1242)" (github#1273
1914961 
)

This reverts commit 0e17abb.
@ayvazjet ayvazjet mentioned this pull request Oct 7, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2023
Open
@B020239 B020239 mentioned this pull request Jun 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Markus85318531 Markus85318531 Markus85318531 approved these changes

@megbird megbird megbird approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StarTrooper08 @nschonni @janiceilene @megbird @Markus85318531