Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note about package immutability #1193

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Conversation

jcansdale
Copy link
Contributor

@jcansdale jcansdale commented Nov 9, 2020

Why:

The following section isn't true.

Public packages: To prevent confusion and build problems, GitHub permanently reserves a package's name and version number. Even if an entire package is deleted, you cannot reuse the deleted package name in any repository owned by the same account.

Private packages: If all versions of a private package are deleted, you can publish a package with a previously used name and version.

To revise or replace a package version, we recommend you publish a new version of your package.

We don't reserve the namespace for public packages. Users can delete/move the associated repository or make the repository private and delete individual package versions. The namespace isn't reserved and would cause problems if it was.

I've removed this section to reflect the current behaviour.

What's being changed:

Removed package-immutability section quoted above.

Check off the following:

@janiceilene
Copy link
Contributor

Thanks for opening a PR @jcansdale! I'll get this triaged for writer review.

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team labels Nov 9, 2020
@lucascosti lucascosti self-assigned this Nov 16, 2020
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 23, 2020
@jcansdale
Copy link
Contributor Author

@lucascosti,

Sorry I missed your reply. 😊

I assume it's incorrect for those too? If so we should remove ☝️ references, and also delete the reusable file.

Yes, there are incorrect as well.

@jcansdale jcansdale removed the stale There is no recent activity on this issue or pull request label Nov 23, 2020
@lucascosti
Copy link
Contributor

Cool, I'll make the changes and get it merged 🚀

Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge when the tests pass ✅

@lucascosti lucascosti merged commit 20a84e9 into main Nov 24, 2020
@lucascosti lucascosti deleted the package-immutability branch November 24, 2020 01:52
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants