-
Notifications
You must be signed in to change notification settings - Fork 60.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove note about package immutability #1193
Conversation
Thanks for opening a PR @jcansdale! I'll get this triaged for writer review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change, @jcansdale!
That reusable is used in a few other articles too:
- https://docs.github.com/en/free-pro-team@latest/packages/managing-container-images-with-github-container-registry/deleting-a-container-image#reserved-package-versions-and-names [source]
- https://docs.github.com/en/free-pro-team@latest/packages/publishing-and-managing-packages/deleting-a-package#reserved-package-versions-and-names [source]
I assume it's incorrect for those too? If so we should remove ☝️ references, and also delete the reusable file.
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
Sorry I missed your reply. 😊
Yes, there are incorrect as well. |
Cool, I'll make the changes and get it merged 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge when the tests pass ✅
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Why:
The following section isn't true.
We don't reserve the namespace for public packages. Users can delete/move the associated repository or make the repository private and delete individual package versions. The namespace isn't reserved and would cause problems if it was.
I've removed this section to reflect the current behaviour.
What's being changed:
Removed
package-immutability
section quoted above.Check off the following: