Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: non-content typo cleanup #1073

Closed
wants to merge 25 commits into from
Closed

chore: non-content typo cleanup #1073

wants to merge 25 commits into from

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Nov 4, 2020 •
edited
Loading

Why:

Typo fixes from #733 that were split out because they require engineering review rather than content reviews.

What's being changed:

  • Various typo fixes
  • Probably product changes required upstream for the changes in data/graphql/ rather than in this PR that might need to be rebased out

Check off the following:

@nschonni nschonni requested a review from a team as a code owner November 4, 2020 20:22
@runleonarun
Copy link
Contributor

runleonarun commented Nov 6, 2020 •
edited
Loading

Hey @nschonni I meant to call out previously that the /lib/graphql and /data/graphql/ content is autogenerated from other code so these change will be overwritten. Can you remove changes to those directories to avoid code conflicts?

The rest looks great to me but I'm sure Engineering will want to approve it.

@nschonni
Copy link
Contributor Author

nschonni commented Nov 6, 2020

@runleonarun yup, I self commented on the last PR around this one myself #733 (comment) 😄
I just left them in here so the right folks can create the internal bugs to they're addressed in the upstream code

heiskr
heiskr approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great. Even if it does cause a merge conflict with some automated tooling, I think these are actually the kinds of conflicts we want lol.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 14, 2020
@janiceilene janiceilene added engineering Will involve Docs Engineering and removed stale There is no recent activity on this issue or pull request labels Nov 16, 2020
@chiedo
Copy link
Contributor

chiedo commented Nov 17, 2020

@rachmari could you give this a final review and merge if you think it's good.

Specifically, this file lib/graphql/static/prerendered-objects.json

@chiedo chiedo added the blocked This issue or PR is currently blocked label Nov 18, 2020
@nschonni nschonni force-pushed the cspell-all branch 3 times, most recently from 7b10749 to d4a13ba Compare November 21, 2020 00:33
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 28, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Nov 30, 2020
@chiedo
Copy link
Contributor

chiedo commented Dec 1, 2020

@nschonni thanks for catching these! These are generated via automation so we’ve taken note of these typos and are going to fix them upstream. Closing this PR and when we fix the issues upstream they’ll be fixed in the repo!

@chiedo chiedo closed this Dec 1, 2020
@nschonni
Copy link
Contributor Author

nschonni commented Dec 1, 2020

@chiedo not all of these are from generated content

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@Loquacity @charislam @mirandaauhl
GSG final steps - Style edits and move to top level (github#1073)
4019ae2 
* Style edits for GSG

* Move GSG to top level

* Fix build

* Apply suggestions from code review

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* Edits per feedback

* Apply suggestions from code review

Committing Miranda's suggestions. I added one more that someone will need to look at.

Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com>

* Update getting-started/create-cagg/create-cagg-basics.md

Co-authored-by: Charis Lam <26616127+charislam@users.noreply.github.com>
Co-authored-by: Ryan Booz <ryan@timescale.com>
Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com>
@avengerfart avengerfart mentioned this pull request Dec 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiskr heiskr heiskr approved these changes

Assignees
No one assigned
Labels
blocked This issue or PR is currently blocked engineering Will involve Docs Engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nschonni @runleonarun @chiedo @heiskr @janiceilene